This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 250386 - Moving an attribute in diagram loses the annotations
Summary: Moving an attribute in diagram loses the annotations
Status: CLOSED FIXED
Alias: None
Product: Tigerstripe (Archived)
Classification: Technology
Component: Annotations (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.4M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-10 03:59 EDT by John Worrell CLA
Modified: 2011-11-23 12:08 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Worrell CLA 2008-10-10 03:59:08 EDT 
This ocurrs when moving between entities of the same type (so annotations should still be valid)
Occurs when drag the attribute in the explorer.

Also occurs when drag the attribute in a class diagram, and also get this error (only first of 4 errors shown).


!ENTRY org.eclipse.tigerstripe.workbench.base 4 2 2008-10-10 10:54:48.336
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.tigerstripe.workbench.base".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.tigerstripe.workbench.ui.instancediagram.diagram.edit.parts.ClassInstanceEditPart.getAdapter(ClassInstanceEditPart.java:84)
	at org.eclipse.tigerstripe.workbench.ui.internal.gmf.TigerstripeShapeNodeEditPart.getModelComponent(TigerstripeShapeNodeEditPart.java:36)
	at org.eclipse.tigerstripe.workbench.ui.internal.gmf.TigerstripeShapeNodeEditPart.shouldRefresh(TigerstripeShapeNodeEditPart.java:57)
	at org.eclipse.tigerstripe.workbench.ui.internal.gmf.TigerstripeShapeNodeEditPart.annotationChanged(TigerstripeShapeNodeEditPart.java:94)
	at org.eclipse.tigerstripe.workbench.internal.core.TigerstripeWorkspaceNotifier$8.run(TigerstripeWorkspaceNotifier.java:267)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
	at org.eclipse.tigerstripe.workbench.internal.core.TigerstripeWorkspaceNotifier.broadcastModelAnnotationChange(TigerstripeWorkspaceNotifier.java:260)
	at org.eclipse.tigerstripe.workbench.internal.core.TigerstripeWorkspaceNotifier.annotationsRemoved(TigerstripeWorkspaceNotifier.java:250)
	at org.eclipse.tigerstripe.annotation.internal.core.AnnotationStorage.fireAnnotationsRemoved(AnnotationStorage.java:236)
	at org.eclipse.tigerstripe.annotation.internal.core.AnnotationStorage.remove(AnnotationStorage.java:168)
	at org.eclipse.tigerstripe.annotation.internal.core.AnnotationManager.deleted(AnnotationManager.java:284)
	at org.eclipse.tigerstripe.workbench.internal.annotation.TigerstripeRefactoringSupport.modelChanged(TigerstripeRefactoringSupport.java:46)
	at org.eclipse.tigerstripe.workbench.internal.core.TigerstripeWorkspaceNotifier$7.run(TigerstripeWorkspaceNotifier.java:214)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
	at org.eclipse.tigerstripe.workbench.internal.core.TigerstripeWorkspaceNotifier.broadcastModelChange(TigerstripeWorkspaceNotifier.java:207)
	at org.eclipse.tigerstripe.workbench.internal.core.TigerstripeWorkspaceNotifier.access$2(TigerstripeWorkspaceNotifier.java:202)
	at org.eclipse.tigerstripe.workbench.internal.core.TigerstripeWorkspaceNotifier$5.run(TigerstripeWorkspaceNotifier.java:181)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

other moves didn’t cause an error
Comment 1 Chris Hartley CLA 2008-10-28 00:49:19 EDT 
in RC4 :

* move works OK if move done in explorer

* annotations still lost if move done from the diagram

* annotations lost if do attribute copy via the explorer
Comment 2 Navid Mehregani CLA 2011-11-23 12:08:19 EST 
Now, the annotations are marked as dangling and user has the option of attaching them to the new attribute.