Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 250136 - [KeyBindings] Conflicts should be accessible through API
Summary: [KeyBindings] Conflicts should be accessible through API
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Prakash Rangaraj CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-08 13:30 EDT by Paul Webster CLA
Modified: 2009-02-25 16:25 EST (History)
1 user (show)

See Also:

Attachments
Patch v01 (8.77 KB, patch)
2008-10-24 07:27 EDT, Prakash Rangaraj CLA 		no flags Details | Diff
Patch v02 (12.90 KB, patch)
2008-11-05 03:42 EST, Prakash Rangaraj CLA 		pwebster: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2008-10-08 13:30:29 EDT 
See org.eclipse.jface.bindings.BindingManager.setActiveBindings(Map, Map, Map, Map)

We currently use org.eclipse.jface.internal.InternalPolicy.currentConflicts to transport the conflicts around, it should be available through the BindingManager (and probably the IBindingService API)

PW
Comment 1 Prakash Rangaraj CLA 2008-10-24 07:27:48 EDT 
Created attachment 116039 [details]
Patch v01

Paul,

    Review and let me know whether I'm in the right direction.
Comment 2 Paul Webster CLA 2008-10-24 13:35:35 EDT 
(In reply to comment #1)
> Created an attachment (id=116039) [details]
> Patch v01

This looks like it's heading in the correct direction.  As discussed, we should probably make the IBindingService method getConflictsFor(TriggerSequence) (and for now we just won't return the entire map of current conflicts).

At the BindingManager level it's probably OK to return the entire map of current conflicts.

PW
Comment 3 Prakash Rangaraj CLA 2008-11-05 03:42:45 EST 
Created attachment 117042 [details]
Patch v02

Patch with the required method & test added
Comment 4 Paul Webster CLA 2008-11-07 12:12:52 EST 
I've released patch v02 with 2 minor changes:
1) turn javadoc references from KeySequence/KeyBinding to TriggerSequence/Binding
2) remove the BindingService#getCurrentConflicts() for now, since it wasn't used API

Thanx, Prakash.

PW
Comment 5 Paul Webster CLA 2008-12-09 10:17:00 EST 
in I20081209-0100
PW