This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 250035 - Some fproj framework source plugins are empty
Summary: Some fproj framework source plugins are empty
Status: RESOLVED FIXED
Alias: None
Product: WTP Releng
Classification: WebTools
Component: releng (show other bugs)
Version: 3.10   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.10.0   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on: 294156
Blocks:
  Show dependency tree
 
Reported: 2008-10-07 20:13 EDT by Konstantin Komissarchik CLA
Modified: 2018-06-29 15:25 EDT (History)
2 users (show)

See Also:


Attachments
Patch to change parent feature of fproj features (2.55 KB, patch)
2008-10-07 20:24 EDT, Konstantin Komissarchik CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2008-10-07 20:13:27 EDT
It turns out that source plugins for both of the plugins in the base fproj framework feature are empty except for manifest and plugin.properties file. The source plugins for the two plugins belonging to the JDT enablement feature are fine.

I looked at the build output and noticed the following... First the source plugin gets build correctly (judging by the number of files copied)...

[build-wtp-wst-sdk] gather.bin.parts:
[build-wtp-wst-sdk]     [mkdir] Created dir: /shared/webtools/projects/wtp-R3.1-I/workdir/tmp/eclipse/plugins/org.eclipse.wst.common.project.facet.core.source_1.3.100.v200809022150
[build-wtp-wst-sdk]      [copy] Copying 2 files to /shared/webtools/projects/wtp-R3.1-I/workdir/tmp/eclipse/plugins/org.eclipse.wst.common.project.facet.core.source_1.3.100.v200809022150
[build-wtp-wst-sdk] 
[build-wtp-wst-sdk] properties:
[build-wtp-wst-sdk] 
[build-wtp-wst-sdk] init:
[build-wtp-wst-sdk] 
[build-wtp-wst-sdk] gather.individual.sources:
[build-wtp-wst-sdk] 
[build-wtp-wst-sdk] copy.src.zip:
[build-wtp-wst-sdk]      [copy] Copying 113 files to /shared/webtools/projects/wtp-R3.1-I/workdir/tmp/eclipse/plugins/org.eclipse.wst.common.project.facet.core.source_1.3.100.v200809022150
[build-wtp-wst-sdk] 

Then it is built again. This time not correctly.

[build-wtp-jst-sdk] gather.bin.parts:
[build-wtp-jst-sdk]     [mkdir] Created dir: /shared/webtools/projects/wtp-R3.1-I/workdir/tmp/eclipse/plugins/org.eclipse.wst.common.project.facet.core.source_1.3.100.v200809022150
[build-wtp-jst-sdk]      [copy] Copying 2 files to /shared/webtools/projects/wtp-R3.1-I/workdir/tmp/eclipse/plugins/org.eclipse.wst.common.project.facet.core.source_1.3.100.v200809022150
[build-wtp-jst-sdk] 

My guess is that this happening because something in JST does an include (instead of reference) of one of the wst.common features that includes the feature that references this plugin. Too many includes and references to make any sense of it.

The JDT Enablement features are referenced directly by the root JST features. I want to see if this problem will go away if the base framework features are referenced directly by the root WST features rather than being first rolled up into common feature.

Will attach a patch that shows the change that I want to try out.
Comment 1 Konstantin Komissarchik CLA 2008-10-07 20:24:02 EDT
Created attachment 114499 [details]
Patch to change parent feature of fproj features

David,

Please review and release this patch. Note that it includes changes in both Common and Releng. The whole thing needs to be released together. Hopefully this will do the trick.
Comment 2 David Williams CLA 2008-10-08 21:17:49 EDT
Your guess is as good as mine. I'll apply and you can re-open if this doesn't solve the problem. 

It's a vague memory, but recall we had some similar problem with JSDT. Maybe it is superstition, but there might be a problem with 2 generate directives in one build.properties. 

Comment 3 David Williams CLA 2009-12-03 20:16:31 EST
I think I have regressed this by fix in bug 294156.
Comment 4 David Williams CLA 2009-12-06 19:21:47 EST
I've refixed this in a similar way, only this time I removed all the redundant wst features from the jst features. This "breaks" anyone using jst zips, but we've never advertised this zips, and told people not to count on them. 

If someone absolutely needs those zips, I'll consider creating them via ant tasks, but its obviously fragile to count on pde build doing it.
Comment 5 David Williams CLA 2009-12-06 20:27:37 EST
btw, the re-fix for this won't show up in 3.2 build until Monday, 12/7. I confirmed fixed in maintenance stream, but just released head fixes.