Community
Participate
Working Groups
Is there a particular reason as to why a folder is used when there's only one item? Looking at the HelpContentPreferencePage class, I don't think I see anything that hints at the fact that the folder will have more than one item.
Agreed, the tab is unnecessary, targeting 3.5.
Created attachment 119798 [details] Patch without the tab Removed the tab from the contents pane.
This looks better. I have a couple more suggested changes to make, then I can apply the patch. On WinXP when the table is not enabled the titles Name, URL and Enabled have a light background and stand out, see screenshot. It feels as though they should have the same background as the rest of the table. When building the label there is a catenation with a space: descLabel.setText(" "+Messages.HelpContentPage_title); //$NON-NLS-1$ In general it is not a good idea to use catenation for any string that uses resources - the string could be in left to right language. I would suggect leaving this extra space out, the dialog seems to align fine without it.
Created attachment 119822 [details] Screenshot showing table heading with light background
Created attachment 119828 [details] Patch without the tab Thanks for the comments. I removed the leading space. Unfortunately I do not see the highlighted table in my environment, so I don't have a fix for that.
Patch committed.
