Community
Participate
Working Groups
Created attachment 114398 [details] Screenshot depicting the strange dialgos. 1. Window > Preferences > Help > Content 2. Check the 'Include help content from a remote infocenter' checkbox. 3. Click the 'Add' button. 4. Question the usage of the 'Location' group widget. 5. Enter in random information and then click 'OK'. 6. Select the added infocenter and then click the 'Delete' button. 7. Question the usage of the 'Location' group widget again and also ponder over the strange 'OK' and 'Cancel' buttons. It seems to me as though somebody decided that Group widgets were the best thing to grace the world since sliced bread.
Targeting Eclipse 3.5
Created attachment 119642 [details] Proposed new look for Preferences Help Content Dialogs I've made a few updates to the dialog layouts, propose that these replace the originals.
(In reply to comment #2) > Created an attachment (id=119642) [details] > Proposed new look for Preferences Help Content Dialogs > > I've made a few updates to the dialog layouts, propose that these replace the > originals. These look quite good. The 'Restore Defaults' dialog is kind of odd though. It says "Note: Clicking cancel on the next pane will Undo this operation.". What exactly is this "next pane"? Also, can you upload your modifications as a patch to this bug?
Created attachment 119781 [details] Patch for updated dialogs In the Restore Dialog, the message "Note: Clicking cancel on the next pane will Undo this operation." is actually referring to the Preferences Pane itself. For example, if you restore defaults, all remote infocenters are removed from the list, but they will be repopulated if you cancel out of the main preferences window. The message may be redundant as most preferences will not be saved if the cancel button is used - however, it is our intention to let the user know they can undo the restore.
(In reply to comment #4) > In the Restore Dialog, the message "Note: Clicking cancel on the next pane will > Undo this operation." is actually referring to the Preferences Pane itself. The term "pane" makes it sound to me like there's another page (like a wizard page) and/or modal dialog that's going to appear. > The message may be redundant as most preferences will not be saved if the > cancel button is used - however, it is our intention to let the user know they > can undo the restore. Are there other preference pages in Eclipse that does this?
Created attachment 119786 [details] Patch for updated dialogs A couple of things - first, made a quick change to the status message for the test connection and view properties dialogs, so the patch has been re-uploaded. > The term "pane" makes it sound to me like there's another page (like a wizard > page) and/or modal dialog that's going to appear. I agree - it does sound like a wizard (and had confused me initially to be honest). This should probably be changed, I'd like to consult with Chris G before I do so. > > The message may be redundant as most preferences will not be saved if the > > cancel button is used - however, it is our intention to let the user know they > > can undo the restore. > > Are there other preference pages in Eclipse that does this? I am not entirely sure what you are asking here. Are you asking if there are other preference pages in eclipse that will undo on cancel, or other pages that inform the user of an undo on cancel?
(In reply to comment #6) > > > The message may be redundant as most preferences will not be saved if the > > > cancel button is used - however, it is our intention to let the user know they > > > can undo the restore. > > > > Are there other preference pages in Eclipse that does this? > > I am not entirely sure what you are asking here. Are you asking if there are > other preference pages in eclipse that will undo on cancel, or other pages that > inform the user of an undo on cancel? Sorry for the confusion, I was asking about the latter.
Actually, running a quick test, it seems that no other help pane has a dialog pop up when pressing restore defaults - so no undo or warning messages come up. I think if we want to be consistent we should remove this dialog box entirely.
(In reply to comment #8) > Actually, running a quick test, it seems that no other help pane has a dialog > pop up when pressing restore defaults - so no undo or warning messages come up. > I think if we want to be consistent we should remove this dialog box entirely. That's what I figured (and is why I asked). I would be happy to hear other UAer's input on this since I imagine there must've been a "good reason" for doing this in the first place.
I agree, we shoud remove this dialog box.
I just reviewed the patch. Overall the dialogs do look better but there are a few changes that still need to be made. One problem I noticed is that there is a line which is writing to standard output and causes messages "true" or "false" to show on the console when testing a connection. This needs to be removed. The view properties dialog still does not look quite right - the values for name, host and path look like disabled text widgets, I think this may be due to the SWT.BORDER style bit in their constructors. It appears that RemoveICDialog is no longer in use - if this is the case you should delete it together with any resources which are only used by this dialog.
Created attachment 119957 [details] Patch for updated dialogs Made the necessary changes.
Fixed
