This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 249553 - Switch off "review complete" checkbox for non-admin users
Summary: Switch off "review complete" checkbox for non-admin users
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EPF (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Onno van der Straaten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-02 19:04 EDT by Peter Haumer CLA
Modified: 2023-02-16 16:16 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Haumer CLA 2008-10-02 19:04:20 EDT 
I had user trying to harvest changes and tick off the "Review complete" checkbox that were not admins. They complained that the box could be selected, but would not stick. Hence, the UI should either switch the box off (just as it switches of the Reviewer field already) or provide and error message when non-admin user try to click it.  

(I think the link_to_done_toggle(version) needs to be inside an if admin? condition as well in various places such as _versions_list.rhtml.)
Comment 1 Onno van der Straaten CLA 2008-10-06 16:08:18 EDT 
Changed the method link_to_done_toggle to disable the checkbox  when the user is not an admin.
Comment 2 Peter Haumer CLA 2008-10-13 22:01:08 EDT 
Did you commit this change? I do not see it.
Comment 3 Onno van der Straaten CLA 2008-10-14 02:19:08 EDT 
I'm very sure I committed this change, but now I don't know where.
Comment 4 Onno van der Straaten CLA 2009-03-09 11:39:34 EDT 
Closing