Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 249411 - Invalid config.ini for feature based .products not including a configurator
Summary: Invalid config.ini for feature based .products not including a configurator
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.2   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 249410
Blocks:
  Show dependency tree
 
Reported: 2008-10-01 18:21 EDT by Andrew Niefer CLA
Modified: 2008-10-06 14:52 EDT (History)
0 users

See Also:

Attachments
patch with test (7.14 KB, patch)
2008-10-06 14:50 EDT, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2008-10-01 18:21:58 EDT 
Consider in 3.4.2

+++ This bug was initially created as a clone of Bug #249410 +++

If a product does not include either org.eclipse.equinox.simpleconfigurator, or org.eclipse.update.configurator, then the pattern is to place all bundles on the osgi.bundles list.

This is broken in the case of feature based .products.  In this case we need to list out the bundles from the assemblydata instead of the plugin list from the .product file.
Comment 1 Andrew Niefer CLA 2008-10-06 14:50:47 EDT 
Created attachment 114345 [details]
patch with test
Comment 2 Andrew Niefer CLA 2008-10-06 14:52:34 EDT 
done for 3.4.2