Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 249318 - [repo] Loading of repository is not safe
Summary: [repo] Loading of repository is not safe
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5 M6   Edit
Assignee: John Arthorne CLA
QA Contact:
URL: http://img505.imageshack.us/img505/92...
Whiteboard:
Keywords:
Depends on:
Blocks: 248602
  Show dependency tree
 
Reported: 2008-10-01 09:38 EDT by Andrew CLA
Modified: 2009-02-11 17:49 EST (History)
1 user (show)

See Also:

Attachments
The screenshot (95.04 KB, image/png)
2008-10-01 09:41 EDT, Andrew CLA 		no flags Details
Log file (126.48 KB, text/plain)
2008-10-13 03:24 EDT, Andrew CLA 		no flags Details
repositories (3.46 KB, application/xml)
2008-10-14 05:43 EDT, Andrew CLA 		no flags Details
First cut at a patch (10.27 KB, patch)
2008-10-14 10:42 EDT, Pascal Rapicault CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew CLA 2008-10-01 09:38:59 EDT 
I have trouble with updates. When I try to update Unexpected error appears and update process fails.

Unfortunately I don't know how i can take stack trace for more details.

See screenshot.
Comment 1 Andrew CLA 2008-10-01 09:41:45 EDT 
Created attachment 113988 [details]
The screenshot
Comment 2 John Arthorne CLA 2008-10-10 16:52:47 EDT 
Please attach your error log file (workspace/.metadata/.log).
Comment 3 Andrew CLA 2008-10-13 03:24:43 EDT 
Created attachment 114919 [details]
Log file

Log file attached
Comment 4 Pascal Rapicault CLA 2008-10-13 22:39:09 EDT 
What did you update from (Eclipse SDK, JEE package, etc.). How did you trigger the update?
Comment 5 Pascal Rapicault CLA 2008-10-13 22:41:49 EDT 
Also could you please attach the list of repositories that you had installed (Available software > Manage Sites...> Export). Thx
Comment 6 Andrew CLA 2008-10-14 05:41:54 EDT 
>What did you update from (Eclipse SDK, JEE package, etc.).

Eclipse SDK with JEE components.

>How did you trigger the update?

1. Menu: Help/Software Updates...
2. Select components for update: all, any or none.
3. Button: Update...
Comment 7 Andrew CLA 2008-10-14 05:43:01 EDT 
Created attachment 115012 [details]
repositories

>Also could you please attach the list of repositories that you had installed
(Available software > Manage Sites...> Export). Thx

Done
Comment 8 Andrew CLA 2008-10-14 06:09:01 EDT 
After starting eclipse.exe -clean the problem is gone.
Comment 9 Pascal Rapicault CLA 2008-10-14 10:42:05 EDT 
Created attachment 115041 [details]
First cut at a patch
Comment 10 Pascal Rapicault CLA 2008-10-14 10:45:05 EDT 
The loading of repository (artifact or metadata) is not safe and can cause unexpected failures. I have attached a preliminary patch wrapping the load call with an ISafeRunnable, but I'm not sure if we would not be better off doing the exception handling ourselves.
Comment 11 John Arthorne CLA 2009-02-11 17:45:16 EST 
Fixed in AbstractRepositoryManager in HEAD. Added FailingMetadataRepositoryFactory as a test case.