Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 249263 - [ds tooling] A missing <implementation> element should be added when the Class field is set in the form-based editor
Summary: [ds tooling] A missing <implementation> element should be added when the Clas...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-01 00:34 EDT by Simon Archer CLA
Modified: 2008-10-09 14:55 EDT (History)
1 user (show)

See Also:


Attachments
DSComponentSection updates (2.35 KB, text/plain)
2008-10-09 14:03 EDT, Rafael Oliveira Nóbrega CLA
caniszczyk: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2008-10-01 00:34:48 EDT
Using Eclipse 3.5M2

When the <implementation> element is missing from the component XML document an error is reported by the editor. But, when you use the form-based editor to set the "Class:" field, the <implementation> element is NOT added to the XML.

The net result is that the "Class:" field is effectively disconnected from the XML document while there is no <implementation> element. This is unfortunate since it requires the user to know to add the missing element by hand.  The form-based editor should relieve the user from such details.

Looking at the form-based editor, the "Class:" field appears to be an attribute of the Component, which is fine, but it does mean that the editor must "fill in the gaps" for the user and add the missing <implementation> element to the XML.
Comment 1 Rafael Oliveira Nóbrega CLA 2008-10-09 14:03:23 EDT
Created attachment 114704 [details]
DSComponentSection updates

if there is no implementation element, we add it before setting the component implementation's class
Comment 2 Chris Aniszczyk CLA 2008-10-09 14:53:52 EDT
Thanks Rafael, this is straightforward.
Comment 3 Chris Aniszczyk CLA 2008-10-09 14:55:19 EDT
done.

> 20091009