Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 249023 - JPA 2.0 Add support for javax.persistence properties
Summary: JPA 2.0 Add support for javax.persistence properties
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL: http://wiki.eclipse.org/EclipseLink/D...
Whiteboard:
Keywords:
: 258664 (view as bug list)
Depends on:
Blocks: 248291 258538
  Show dependency tree
 
Reported: 2008-09-29 15:15 EDT by Gordon Yorke CLA
Modified: 2022-06-09 10:36 EDT (History)
6 users (show)

See Also:

Attachments
Patch that implements standard properties feature (17.79 KB, patch)
2009-02-24 20:39 EST, Darani Yallapragada CLA 		no flags Details | Diff
updated patch with changes suggested by Andrei (25.96 KB, patch)
2009-02-26 15:10 EST, Darani Yallapragada CLA 		no flags Details | Diff
Slightly updated patch (22.56 KB, patch)
2009-03-03 18:13 EST, Andrei Ilitchev CLA 		no flags Details | Diff
Correction: Rolled back changes to JUnitTestCaseHelper - it's a core (not jpa) testing file, the changes made some core qa tests to fail. (1.57 KB, patch)
2009-03-04 15:59 EST, Andrei Ilitchev CLA 		no flags Details | Diff
Changed all core tests to use new javax.persistence properties (11.50 KB, patch)
2009-03-06 11:58 EST, Andrei Ilitchev CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Yorke CLA 2008-09-29 15:15:22 EDT 
The specification has added standardized persistence unit properties. Support must be added for these properties.

See http://wiki.eclipse.org/index.php?title=EclipseLink/Development/JPA_2.0/standard_properties
Comment 1 Gordon Yorke CLA 2008-12-12 10:40:27 EST 
*** Bug 258664 has been marked as a duplicate of this bug. ***
Comment 2 Karen Butzke CLA 2009-01-14 12:59:00 EST 
this includes the javax.persistence.query.timeout property
Comment 3 Doug Clarke CLA 2009-02-02 15:09:16 EST 
Added URL link to wiki page for tracking requirements/design/issues
Comment 4 Darani Yallapragada CLA 2009-02-24 20:39:52 EST 
Created attachment 126658 [details]
Patch that implements standard properties feature 

Will update the wiki once this patch is committed. The above patch implements "query timeout" and also adds support for javax.persistence properties. JUnit tests are also included. Tested for regression and see no regression.
Comment 5 Darani Yallapragada CLA 2009-02-26 15:10:34 EST 
Created attachment 126893 [details]
updated patch with changes suggested by Andrei
Comment 6 Andrei Ilitchev CLA 2009-03-03 18:13:40 EST 
Created attachment 127405 [details]
Slightly updated patch

Removed PessimisticLockTimeoutProp from PropertiesHandler; fixed EntityManagerJUnitTestSuite.testEMFactoryCloseAndOpen
Comment 7 Andrei Ilitchev CLA 2009-03-03 18:14:13 EST 
Checked the fix into trunk.
Comment 8 Andrei Ilitchev CLA 2009-03-04 15:59:52 EST 
Created attachment 127553 [details]
Correction: Rolled back changes to JUnitTestCaseHelper - it's a core (not jpa) testing file, the changes made some core qa tests to fail.
Comment 9 Andrei Ilitchev CLA 2009-03-06 11:58:00 EST 
Created attachment 127835 [details]
Changed all core tests to use new javax.persistence properties

My last patch broke some tests. The reason being that some core test objects were still using the old eclipselink.jdbc.user properties, where some tests expected PersietenceUnitProperties.JDBC_USER.
Now all "eclipselink.jdbc.user/password/url/driver" properties in foundation changed to the new "javax.persistence.jdbc.user/password/url/driver" properties.

Note that the old properties still left in some jpa tests (performance, memory leak tests) - but there the properties passed directly to createEMF method, which is ok.
Comment 10 Peter Krogh CLA 2009-08-26 09:44:47 EDT 
Mass update to change fixed in target.
Comment 11 Peter Krogh CLA 2009-08-26 09:47:09 EDT 
Mass update to change fixed in target.
Comment 12 Peter Krogh CLA 2009-08-26 09:51:04 EDT 
Mass update to change fixed in target.
Comment 13 Peter Krogh CLA 2009-08-26 09:53:30 EDT 
Mass update to change fixed in target.
Comment 14 Eclipse Webmaster CLA 2022-06-09 10:36:07 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink