Community
Participate
Working Groups
Created attachment 113285 [details] patch file to add sorting to Team Editors grid Build ID: I20080617-2000 Steps To Reproduce: 1. On a CVS project that is using the editors file, right click the project and choose Team -> Show Editors. 2. Look at the resulting CVS Editors view. The columns are not sortable. You cannot click on the column headers like every other grid and you can't right-click to change sort options either. More information: When you have 100 people working on the same project, it's nice to know who's editing a file. It's also nice to know what files I've marked as being an editor. The company I work for uses this as a crude mechanism to enforce one-editor-at-a-time behavior. When I looked at the code for this view, I found that it simply did not have anything in it to support sorting. I decided to add it myself. Hopefully I can attach it to this bug. If not please email me and I'll be very happy to supply a patch file.
Created attachment 113881 [details] Patch v02 Thanks for the patch Brain, I did have a look at it and I made some changes. Could you check if it still works as expected? If yes I will apply it asap.
Created attachment 113882 [details] mylyn/context/zip
(In reply to comment #1) > Created an attachment (id=113881) [details] > Patch v02 > > Thanks for the patch Brain, I did have a look at it and I made some changes. > Could you check if it still works as expected? If yes I will apply it asap. > I like the way you implemented it much better. However, it seems that dates do not sort at all now. I'm trying to find out why now.
Local files not yet checked into CVS have a null user name, date and computer name. At the top of your extractDate(String) method, add a null check on dateString: if ( dateString == null ) return -1;
Created attachment 113963 [details] Patch v03 Sorry, I don't use Watch/Edit on daily basis, so I don't know all the cases. However, from what I see you cannot even run Show Editors action on an unshared file (not yet checked in). I added the check anyway, just to be on the safe side. Thanks for testing, let me know if there is anything else to add. If you're fine with the fix as it is, I will release immediately.
(In reply to comment #5) > Created an attachment (id=113963) [details] > Patch v03 > > Sorry, I don't use Watch/Edit on daily basis, so I don't know all the cases. > However, from what I see you cannot even run Show Editors action on an unshared > file (not yet checked in). I added the check anyway, just to be on the safe > side. Thanks for testing, let me know if there is anything else to add. If > you're fine with the fix as it is, I will release immediately. > You can run Show Editors on a project. A project can have files not yet added to CVS. With the null check in place, I'm very happy with the fix. THANKS!
Latest patch released to HEAD. Thanks Brian!
