Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 248276 - [ds tooling] When we create a project using "Hello OSGI DS" template the Error reporter doesn't work.
Summary: [ds tooling] When we create a project using "Hello OSGI DS" template the Erro...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-23 10:27 EDT by Rafael Oliveira Nóbrega CLA
Modified: 2008-09-30 16:29 EDT (History)
2 users (show)

See Also:


Attachments
DSEditor Updates... (2.36 KB, text/plain)
2008-09-30 16:00 EDT, Rafael Oliveira Nóbrega CLA
caniszczyk: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Oliveira Nóbrega CLA 2008-09-23 10:27:24 EDT
If you create a plug-in project using DS template, the error reporter doesn't work.
Comment 1 Chris Aniszczyk CLA 2008-09-23 10:28:46 EDT
This is because I think on save, we should be checking if we have the DS builder added to the DS file or not.

Currently, we only add the builder when you create a new DS file so we don't work with existing files if they are in a project w/o the DS builder.
Comment 2 Rafael Oliveira Nóbrega CLA 2008-09-28 09:50:39 EDT
Chris,

I created a method using DSCreationOperation code, called addDSBuilder.

I thought to add it to DSEditor to be added when the editor is created.

I find a place where it works, but I'm not sure if it is the best place. I placed it in the method: createResourceContexts(InputContextManager, IFileEditorInput).
So I added the statement: addDSBuilder((IFile) input.getFile());

I tested with some projects, and it's seems ok for me.

Can you see any mistake?
Comment 3 Rafael Oliveira Nóbrega CLA 2008-09-30 16:00:35 EDT
Created attachment 113914 [details]
DSEditor Updates...

This is the patch to add DS Builder while opening the DS Editor.

Could you please see if its ok to place the addDSBuild() in the DSEditor file?
Comment 4 Chris Aniszczyk CLA 2008-09-30 16:28:36 EDT
done.

> 20090930

I changed the logic to move the adding the builder to the save operation. This requires people to modify the file and than the builder gets attached. This is a similar thing that WTP does with XML files not created by WTP.