Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 248226 - [ds tooling] Referenced Services should have Up/Down buttons
Summary: [ds tooling] Referenced Services should have Up/Down buttons
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-22 21:22 EDT by Simon Archer CLA
Modified: 2008-11-05 12:28 EST (History)
1 user (show)

See Also:

Attachments
DSReferenceSection updates (7.47 KB, text/plain)
2008-10-31 15:36 EDT, Rafael Oliveira Nóbrega CLA 		no flags Details
mylyn/context/zip (2.81 KB, application/octet-stream)
2008-11-03 16:36 EST, Chris Aniszczyk CLA 		no flags Details
DSReferenceSection update (2.81 KB, text/plain)
2008-11-05 11:30 EST, Rafael Oliveira Nóbrega CLA 		caniszczyk: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2008-09-22 21:22:38 EDT 
Eclipse 3.5M2.

Technically speaking, the order of <reference> elements is significant, so maybe we should have Up/Down buttons available in the Referenced Services section of the Service Component editor.

Why is order significant?  Well, the order of the <reference> elements is the order that their bind methods will be called before the component is activated, and the reverse order that their unbind methods will be called before the component is deactivated.  Of course bind/unbind method attributes are optional. For more details see section 112.5.7 and 112.5.13 in the OSGi spec.

I am hesitating on this one because I do not want to clutter the UI unnecessarily.
Comment 1 Rafael Oliveira Nóbrega CLA 2008-09-23 19:56:28 EDT 
Chris??

Should I implement this?
Comment 2 Rafael Oliveira Nóbrega CLA 2008-10-31 15:36:00 EDT 
Created attachment 116651 [details]
DSReferenceSection updates

Up and Down buttons created
Comment 3 Chris Aniszczyk CLA 2008-11-03 16:36:37 EST 
done.

> 20091103

I made some changes and fixes Rafael.

Thanks!
Comment 4 Chris Aniszczyk CLA 2008-11-03 16:36:50 EST 
Created attachment 116871 [details]
mylyn/context/zip
Comment 5 Simon Archer CLA 2008-11-04 10:57:46 EST 
Using Eclipse 3.5M3 from HEAD.

Up/Down buttons are always problematic it seems! As implemented today the buttons only really work for a single selection, yet they are enabled for multiple selections.  

- Either enable the buttons for only a single selection.
- Or fix the behavior for multiple selections:
    - Try selecting multiple adjacent items.
    - Try selecting multiple non-adjacent items.

Frankly, the list of referenced services is always going to be short enough that supporting only single selection will be more than adequate.
Comment 6 Simon Archer CLA 2008-11-04 11:01:51 EST 
I just tried the Up/Down buttons in the Properties section and it works perfectly for both single and multiple selections.  This was addressed by bug 248216.
Comment 7 Rafael Oliveira Nóbrega CLA 2008-11-05 11:30:43 EST 
Created attachment 117113 [details]
DSReferenceSection update

Done!
Comment 8 Chris Aniszczyk CLA 2008-11-05 11:32:34 EST 
done.

Thanks Rafael!

> 20091105
Comment 9 Simon Archer CLA 2008-11-05 12:28:10 EST 
That works great, thanks guys.