Comment 1 Chris Aniszczyk 2008-09-22 20:55:28 EDT

I'm not for automatic expansion here, how about just remembering the expansion state?

Comment 2 Simon Archer 2008-09-22 21:09:07 EDT

Nah.  How about adding the number of property elements to the title of the section, so you can see without expanding if there are any?  So you'd get:

  Properties (4)

If there are 4 elements, and simply:

  Properties

When then are none.  I'd rather NOT see "Properties (0)".

Comment 3 Chris Aniszczyk 2008-09-22 21:09:45 EDT

I like that, it's kind of "fancy pants" :)

Comment 4 Rafael Oliveira Nóbrega 2008-09-30 15:56:20 EDT

Created attachment 113913 [details]
Properties Section title updating

Now we have the quantity-based title updating feature. :)

If we have no properties, the title will be: Properties
If we have 2 properties: Properties (2).

And so on... :)

Comment 5 Chris Aniszczyk 2008-09-30 16:44:44 EDT

Thanks Rafael! This looks good!

I've opted to not save the state as we don't do this anywhere else in PDE.

I modified the patch to show Properties (0) too... instead of just Properties.

Thanks, this  is cool!

Comment 6 Chris Aniszczyk 2008-09-30 16:45:04 EDT

fixed.

> 20090930

Comment 7 Simon Archer 2008-09-30 21:50:11 EDT

While testing the tooling in a runtime workbench I found this in my console.  it sounds related to this bug, but I might be wrong.

Exception in thread "org.eclipse.jface.text.reconciler.MonoReconciler" org.eclipse.swt.SWTException: Invalid thread access
	at org.eclipse.swt.SWT.error(SWT.java:3777)
	at org.eclipse.swt.SWT.error(SWT.java:3695)
	at org.eclipse.swt.SWT.error(SWT.java:3666)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:463)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:355)
	at org.eclipse.swt.widgets.Table.getItemCount(Table.java:2360)
	at org.eclipse.pde.internal.ds.ui.editor.DSPropertiesSection.updateTitle(DSPropertiesSection.java:174)
	at org.eclipse.pde.internal.ds.ui.editor.DSPropertiesSection.modelChanged(DSPropertiesSection.java:451)
	at org.eclipse.pde.internal.core.text.AbstractEditingModel.fireModelChanged(AbstractEditingModel.java:229)
	at org.eclipse.pde.internal.core.text.AbstractEditingModel.reload(AbstractEditingModel.java:145)
	at org.eclipse.pde.internal.core.text.AbstractEditingModel.reconciled(AbstractEditingModel.java:170)
	at org.eclipse.pde.internal.ui.editor.text.ReconcilingStrategy.notifyParticipants(ReconcilingStrategy.java:53)
	at org.eclipse.pde.internal.ui.editor.text.ReconcilingStrategy.reconcile(ReconcilingStrategy.java:48)
	at org.eclipse.jface.text.reconciler.MonoReconciler.process(MonoReconciler.java:77)
	at org.eclipse.jface.text.reconciler.AbstractReconciler$BackgroundThread.run(AbstractReconciler.java:206)

Comment 8 Chris Aniszczyk 2008-09-30 21:53:55 EDT

updated from HEAD.

I just fixed that one :)