Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 247731 - [Browser] Eclipse requires restart after changing mozilla browser location in preferences
Summary: [Browser] Eclipse requires restart after changing mozilla browser location in...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 464153
  Show dependency tree
 
Reported: 2008-09-17 16:50 EDT by Shawn Minto CLA
Modified: 2016-02-08 08:34 EST (History)
2 users (show)

See Also:

Attachments
patch (1.61 KB, patch)
2008-09-17 17:03 EDT, Shawn Minto CLA 		cgold: iplog+
Details | Diff
mylyn/context/zip (3.35 KB, application/octet-stream)
2008-09-17 17:03 EDT, Shawn Minto CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2008-09-17 16:50:22 EDT 
If a user tries to change the location of the Firefox executable in the "Web Browser" preference page, the user must restart Eclipse, but they are not told this.  This is due to the MozillaFactory creating a single instance of a MozillaBrowser and never ensuring that the executable paths are the same.  Changing this preference may look like it doesn't do anything (or that they did something wrong) to the user since their new preference value is not properly used.
Comment 1 Shawn Minto CLA 2008-09-17 17:03:21 EDT 
Created attachment 112828 [details]
patch

Attached is a simple patch that fixes this by comparing the executable location with the one that the MozillaBrowser uses.  If they are different, it will create a new MozillaBrowser using the new location.
Comment 2 Shawn Minto CLA 2008-09-17 17:03:30 EDT 
Created attachment 112829 [details]
mylyn/context/zip
Comment 3 Chris Goldthorpe CLA 2008-10-06 14:13:34 EDT 
Patch looks good, targeting Eclipse 3.5.
Comment 4 Chris Goldthorpe CLA 2008-10-24 18:45:20 EDT 
Patch applied to HEAD