Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 247712 - service model active configuration never changes
Summary: service model active configuration never changes
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 2.1M2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 2.1RC1   Edit
Assignee: Vivian Kong CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-17 15:27 EDT by Mike Kucera CLA
Modified: 2008-10-10 16:10 EDT (History)
1 user (show)

See Also:


Attachments
proposed patch (4.87 KB, patch)
2008-10-09 15:15 EDT, Vivian Kong CLA
recoskie: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kucera CLA 2008-09-17 15:27:00 EDT
The ServiceModelManager has a method setActiveConfiguration() which is never called from anywhere. So when the active build configuration is changed the corresponding service model configuration is not set to active. The first service model configuration created for a project becomes the active one and it never changes.

Steps to reproduce:
- Create an RDT project with one configuration, call it Default
- Set up the service model using the wizard and create the project
- Create a new build configuration, call it Release
- Switch to the Release configuration
- Open the Service Model properties page, make edits. The edits effect the Release configuration.
- The problem is the ServiceModelManager still thinks the active configuration is Default, so the changes to the Release configuration are not visible.

When switching build configurations the service model configuration should be switched too.

Also the new configuration dialog has a section to allow copying of settings from an existing configuration. This should copy the service model as well.
Comment 1 Mike Kucera CLA 2008-09-17 16:05:38 EDT
Question: is there supposed to be a correspondence between CDT build configurations and RDT service model configurations? Right now RDT uses the build info to get the name it will use for the service configuration.

Perhaps it would be best to manage service model configurations separately. We could add a section to the Service Model properties page for creating and managing service model configurations.

I'm thinking its likely the user will only want one service model configuration, so the user should be able to create build configurations without worrying about the service model. Also the user may want to switch build configurations without necessarily switching service model configurations.

Thoughts?
Comment 2 Chris Recoskie CLA 2008-10-09 11:11:43 EDT
We had intended that service model configurations would map to build configurations.  But upon further thought, I think you're right.  We should probably change this.
Comment 3 Chris Recoskie CLA 2008-10-09 14:49:24 EDT
Given that we (as a rule) can't do any new UI right now, I would say that the best way to go about this for this release is to only have one configuration, which is always the default.
Comment 4 Vivian Kong CLA 2008-10-09 15:15:24 EDT
Created attachment 114707 [details]
proposed patch

In this patch, new service model configuration will not use the active build configuration's name.  All service model configurations are created with 1 name, therefore there's only 1 configuration for each project

Unfortunately, this will break existing projects.
Comment 5 Chris Recoskie CLA 2008-10-10 16:10:06 EDT
Committed to HEAD.  Thanks.