Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 247175 - navigation isn't working
Summary: navigation isn't working
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 2.1M2   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: 2.1RC1   Edit
Assignee: Chris Recoskie CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-12 11:22 EDT by Chris Recoskie CLA
Modified: 2008-10-10 15:56 EDT (History)
0 users

See Also:


Attachments
proposed patch (91.65 KB, patch)
2008-10-10 12:37 EDT, Mike Kucera CLA
recoskie: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Recoskie CLA 2008-09-12 11:22:24 EDT
F3 and the "Go to declaration" menu item both don't take you to the declaration.  Instead it opens a blank <text> editor.
Comment 1 Chris Recoskie CLA 2008-09-18 15:25:45 EDT
It looks like this was never actually implemented.  Awesome :-/

Right now it's all hardwired to go to the local index.  Hence why it has problems, given the index is empty.

I'm going to have to add a command to the miner to handle this.
Comment 2 Mike Kucera CLA 2008-10-10 12:37:41 EDT
Created attachment 114819 [details]
proposed patch

Adds support for navigation (F3)

Its a big patch, and effects four of the rdt plugins. I added a new package to hold the navigation classes in the core plugin. 

Good news is that I did end up getting it to work with CElements, so if there is multiple declarations the selection dialog will appear.

The only thing that doesn't work is navigation to system headers. I'm getting an exception from inside CModelManager. There is a TODO task that says crecoskie right above the spot where the exception comes from (line 478).

It should be very easy to get the hyperlinker to work now.
Comment 3 Chris Recoskie CLA 2008-10-10 15:55:17 EDT
I've applied this to HEAD.  Thanks Mike.

There is a bug in this, in that it's not resolving declarations from one project to another.   I'll file a separate bug for that.