Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 246804 - Missing NLS message in org.eclipse.pde.internal.core.pderesources
Summary: Missing NLS message in org.eclipse.pde.internal.core.pderesources
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 246834 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-09-09 21:56 EDT by Olivier Thomann CLA
Modified: 2008-09-11 02:47 EDT (History)
6 users (show)

See Also:


Attachments
patch correcting the NLS missing key issue + default level set to ignore for errors wrt versions (2.63 KB, patch)
2008-09-10 10:34 EDT, Benjamin Cabé CLA
caniszczyk: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2008-09-09 21:56:28 EDT
Using eclipse.buildId=I20080909-1121
java.fullversion=J2RE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260-20080415_18762 (JIT enabled, AOT enabled)
J9VM - 20080415_018762_lHdSMr
JIT  - r9_20080415_1520
GC   - 20080415_AA
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=fr_CA
Command-line arguments:  -os win32 -ws win32 -arch x86 -consolelog -console, I got lot of errors in my workspace for many projects and the error message was:

NLS missing message: BundleErrorReporter_MissingVersion in: org.eclipse.pde.internal.core.pderesources
Comment 1 Markus Keller CLA 2008-09-10 04:56:10 EDT
*** Bug 246834 has been marked as a duplicate of this bug. ***
Comment 2 Markus Keller CLA 2008-09-10 04:57:34 EDT
In every plug-in MANIFEST.MF, I get tons of errors with a broken message
"NLS missing message: BundleErrorReporter_MissingVersion in:
org.eclipse.pde.internal.core.pderesources", 1 for each package in the
"Export-Package:" and "Require-Bundle:" sections.

Please request a rebuild when this is fixed.
Comment 3 Dani Megert CLA 2008-09-10 05:03:18 EDT
How can this can happen? Is there no self-hosting taking place on your own code? Are there no automated or at least manual smoke tests?
Comment 4 Benjamin Cabé CLA 2008-09-10 05:55:44 EDT
(In reply to comment #3)
> How can this can happen? Is there no self-hosting taking place on your own
> code? Are there no automated or at least manual smoke tests?
> 

Daniel, I don't understand your comment at all! :) Perhaps you commented on a wrong bug?
The issue here is "simply" that Chris forgot to commit its local 'pderesources.properties' while fixing bug 205198, I suppose
Comment 5 Dani Megert CLA 2008-09-10 06:02:42 EDT
>Daniel, I don't understand your comment at all! :) Perhaps you commented on a
>wrong bug?
No, I did not. The point is, all users that switch to the new build are toast. Their workspace is full of errors. Committers should at least run their changes once and I would expect such failures to be detected by automated tests. Cleary, PDE people did not self-host on their newest code before RELEASING it to an I-build.
Comment 6 Darin Wright CLA 2008-09-10 09:46:25 EDT
Chris, why is the default severity for a missing import "Error"? I think it should be warning or ignore at best (until the SDK decides on how it wants to deal with package versioning). We shouldn't be putting errors in the face of developers until we have tooling to fix the problems (and API tooling has no support for package version validation).

This is a blocker and needs to be fixed so we have a decent I-build before the milestone.
Comment 7 Darin Wright CLA 2008-09-10 10:10:56 EDT
I found the workaround to this is to set the following three severity settings to "Ignore":

Preferences > Plug-in Development > Compilers > Versioning:

* Missing versions on required bundles
* Missing versions on exported packages
* Missing versions on imported packages
Comment 8 Benjamin Cabé CLA 2008-09-10 10:28:49 EDT
For some obscure reason, the patch for bug 205198 hasn't been committed entirely (org.eclipse.pde.core has been skipped).
I'll attach the patch corresponding to the diff between patch for bug 205198 and what actually is in HEAD.
Comment 9 Chris Aniszczyk CLA 2008-09-10 10:31:21 EDT
morining all. I'm investigating the issue now.
Comment 10 Benjamin Cabé CLA 2008-09-10 10:34:24 EDT
Created attachment 112206 [details]
patch correcting the NLS missing key issue + default level set to ignore for errors wrt versions

as said in my previous comment, this patch is *just* the result of applying the patch for 205198 to HEAD

@Daniel: I tested and it works :)
Comment 11 Chris Aniszczyk CLA 2008-09-10 10:44:38 EDT
committed and tagged.

I will issue a rebuild.

I am not sure why org.eclipse.pde.core wasn't committed from my old patch in bug 205198

Thanks Ben.
Comment 12 Dani Megert CLA 2008-09-11 02:47:03 EDT
Verified in N20080910-2000.