Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 246391 - product export from the ui does not generate bundles.info
Summary: product export from the ui does not generate bundles.info
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows Vista
: P3 major (vote)
Target Milestone: 3.4.2   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 240053
  Show dependency tree
 
Reported: 2008-09-05 11:10 EDT by Chris Aniszczyk CLA
Modified: 2008-10-03 12:10 EDT (History)
2 users (show)

See Also:
jeffmcaffer: pmc_approved+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-09-05 11:10:06 EDT 
+++ This bug was initially created as a clone of Bug #240053 +++

We need to remove the PDE Build killswitch on product export in order for bug 240053 to happen.
Comment 1 Chris Aniszczyk CLA 2008-09-08 12:12:23 EDT 
Andrew, are you comfortable doing this for 3.4.1 if I do bug 240053 for 3.4.1 also? I think this is a major issue... it's been coming up in the newsgroups quite a bit. If we go for 3.4.1, we will need to seek PMC approval.
Comment 2 Chris Aniszczyk CLA 2008-09-08 15:43:06 EDT 
poke
Comment 3 Andrew Niefer CLA 2008-09-08 15:56:10 EDT 
Yes, this is really nothing on its own.  The question then is are we comfortable with 240053 in 3.4.1.  That is, is UI comfortable abdicating its generation of various product files in favor of those generated by build.

If you prefer this method over fixing any specific problems with UI generation, then I will release this.  You get to do the work of getting our approvals.
Comment 4 Chris Aniszczyk CLA 2008-09-08 16:03:51 EDT 
yes, I'm in favor of using PDE Build to generate the various artifacts like config.ini that were a source of confusion when we had two code paths to do this.
Comment 5 Chris Aniszczyk CLA 2008-09-08 16:12:25 EDT 
Can you release the change for this week's i-build too Andrew? For 3.5M2?
Comment 6 Andrew Niefer CLA 2008-09-08 17:23:53 EDT 
In head for M2.
Comment 7 Jeff McAffer CLA 2008-09-09 13:14:14 EDT 
approving for 3.4.2
Comment 8 Chris Aniszczyk CLA 2008-10-02 17:36:43 EDT 
Andrew, can you release this for 3.4.2?

I released my changes for 3.4.2 today.

When you do, I'll tag.
Comment 9 Andrew Niefer CLA 2008-10-03 12:10:20 EDT 
done in 3.4.2.  Project will be tagged early next week after bug 249411 is considered