Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 245854 - [Net] Windows native header file's name too long
Summary: [Net] Windows native header file's name too long
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-01 06:17 EDT by Pawel Pogorzelski CLA
Modified: 2009-06-02 06:55 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (7.41 KB, patch)
2008-09-02 12:11 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Recompiled library jWinHttp.dll (43.50 KB, application/octet-stream)
2008-09-02 12:13 EDT, Pawel Pogorzelski CLA 		no flags Details
Patch_v01B (981 bytes, patch)
2008-09-02 12:18 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (9.69 KB, patch)
2008-09-03 06:37 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Recompiled library (43.50 KB, application/x-msdownload)
2008-09-03 06:40 EDT, Pawel Pogorzelski CLA 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2008-09-01 06:17:11 EDT 
Build ID: M20080827-2000

Steps To Reproduce:
The name is org_eclipse_core_internal_net_proxy_win32_winhttp_WinHttp.hwhich is a bit to long:) This is the default header file generated by javah utility but it doesn't mean it can't be changed.
Comment 1 Pawel Pogorzelski CLA 2008-09-02 12:11:49 EDT 
Created attachment 111497 [details]
Patch_v01
Comment 2 Pawel Pogorzelski CLA 2008-09-02 12:13:48 EDT 
Created attachment 111498 [details]
Recompiled library jWinHttp.dll

The library had to be recompiled so it corresponds to the modified sources. Szymon, are you OK with the changes?
Comment 3 Pawel Pogorzelski CLA 2008-09-02 12:18:52 EDT 
Created attachment 111499 [details]
Patch_v01B

One more thing, updated BUILD_INFO.TXT.
Comment 4 Szymon Brandys CLA 2008-09-03 05:32:34 EDT 
(In reply to comment #2)
> Created an attachment (id=111498) [details]
> Recompiled library jWinHttp.dll
> 
> The library had to be recompiled so it corresponds to the modified sources.
> Szymon, are you OK with the changes?

I think that we could add version to the lib name. Something like
jWinHttp-1.0.0.dll. What do you think Pawel?
Comment 5 Pawel Pogorzelski CLA 2008-09-03 06:37:32 EDT 
Created attachment 111565 [details]
Patch_v02

I agree with you, Szymon - the native windows library should be versioned as well as the Linux one is.

I chose the Linux naming convention so the new library name is jWinHttp-1.0.0.dll. This convention is simple and related to eclipse versioning system as well. Those are reasons why I dropped the Windows naming convention.
Comment 6 Pawel Pogorzelski CLA 2008-09-03 06:40:12 EDT 
Created attachment 111566 [details]
Recompiled library

The recompiled library. Update of the BUILD_INFO.txt is already included in the Patch_02.

Szymon, does it look good now?
Comment 7 Szymon Brandys CLA 2008-09-03 06:46:13 EDT 
Looks good. Thanks Pawel.
Comment 8 Tomasz Zarna CLA 2008-09-03 10:07:08 EDT 
Released to HEAD, updated build.properties for the fragment as well.