Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 245708 - indexer preferences not passed to remote indexer
Summary: indexer preferences not passed to remote indexer
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 2.1M2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: Future   Edit
Assignee: Mike Kucera CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-29 11:23 EDT by Mike Kucera CLA
Modified: 2011-05-14 06:37 EDT (History)
0 users

See Also:


Attachments
preliminary patch (30.18 KB, patch)
2008-10-16 12:16 EDT, Mike Kucera CLA
g.watson: iplog+
Details | Diff
proposed patch (21.47 KB, patch)
2009-07-13 16:42 EDT, Mike Kucera CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kucera CLA 2008-08-29 11:23:21 EDT
CDT allows the user to choose several preferences for the indexer. These preferences are maintained by the class IndexerPreferences.

RDT is not passing these preferences to the remote indexer. There are several set() methods in the StandaloneIndexer class for setting up these options, but they are not being called.

I propose to fix this in a similar way to how remote scanner info works. Currently when the remote indexer is invoked it is sent a scanner info provider. The preferences object can also be sent over as well. 

I also propose that we introduce a parameter object for the subsystem methods that invoke the remote indexer (call it RemoteIndexerData or something). This parameter object will store the scanner info provider and the preferences in a single object that is passed as a single parameter. Otherwise we will end up with too many parameters to these methods. This will also make it very easy to pass additional data to the remote indexer in the future, because adding a field to the parameter object does not require that the signature of the subsystem method be changed.

Introduce Parameter Object:
http://books.google.ca/books?id=1MsETFPD3I0C&pg=PA295&lpg=PA8&dq=Martin+Fowler+refactoring&output=html&sig=ACfU3U1i3onoccylP-NJQKBIJRA88C5c5Q
Comment 1 Chris Recoskie CLA 2008-10-09 12:50:49 EDT
I'll leave the target milestone blank on this one so you can self-triage.
Comment 2 Mike Kucera CLA 2008-10-16 12:12:01 EDT
Looks like the standalone indexer is ignoring the indexer preferences. I'll open a bug on CDT for that. But for now this is looking to be a lot more complicated than I thought.
Comment 3 Mike Kucera CLA 2008-10-16 12:13:56 EDT
Opened bug 251100
Comment 4 Mike Kucera CLA 2008-10-16 12:16:24 EDT
Created attachment 115272 [details]
preliminary patch

This is a patch of the work I have done so far on this bug. I'm just posting it here for safekeeping. Basically it passes the preferences to the remote indexer, however the preferences are ignored.
Comment 5 Chris Recoskie CLA 2008-10-20 14:38:45 EDT
If there is nothing to do here for this release, then please target this bug at Future.
Comment 6 Mike Kucera CLA 2009-07-13 16:42:50 EDT
Created attachment 141455 [details]
proposed patch
Comment 7 Mike Kucera CLA 2009-07-16 15:10:49 EDT
Fixed in 2.1 and head.