Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244697 - [CommonNavigator] Remove/fix .api-filter
Summary: [CommonNavigator] Remove/fix .api-filter
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 261176
Blocks:
  Show dependency tree
 
Reported: 2008-08-20 10:00 EDT by Francis Upton IV CLA
Modified: 2009-02-10 03:55 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francis Upton IV CLA 2008-08-20 10:00:50 EDT
This was introduced in the fix to bug 212389, however it's too broad, and was also required because of a bug in the API tooling, bug 244673.
Comment 1 Francis Upton IV CLA 2008-08-20 10:01:52 EDT
(from bug 212389)

Furthermore, the released filter is too broad. Only the last entry is
necessary:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.ui.navigator" version="2">
    <resource path="src/org/eclipse/ui/navigator/NavigatorActionService.java"
type="org.eclipse.ui.navigator.NavigatorActionService">
        <filter id="338944126">
            <message_arguments>
                <message_argument
value="org.eclipse.ui.navigator.NavigatorActionService"/>
                <message_argument
value="getActionProviderInstance(CommonActionProviderDescriptor)"/>
            </message_arguments>
        </filter>
    </resource>
</component
Comment 2 Francis Upton IV CLA 2008-08-20 10:08:47 EDT
Released suggested more narrow API filter to HEAD.

Did not see the point in fixing R3_4Maintenance.

Will keep this open until the other bug is fixed and the filter can be removed.
Comment 3 Olivier Thomann CLA 2008-08-27 15:38:16 EDT
I have a fix for bug 244673, but I still have some leak problems reported.
Comment 4 Francis Upton IV CLA 2008-08-27 15:44:23 EDT
(In reply to comment #3)
> I have a fix for bug 244673, but I still have some leak problems reported.
> 
There are API leaks in the CN that we know about, are these what you are running into?
Comment 5 Francis Upton IV CLA 2009-01-15 04:47:53 EST
There are several items in the .api-filter that will always be there (until E4 at least) because they have to do with adding API directives that were only in the text previously.

There remains only one item left due to a problem in the API mechanism, and this is covered by bug 261176.
Comment 6 Francis Upton IV CLA 2009-02-10 03:55:23 EST
The current API filters for the CNF are good.