Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244673 - Invalid API problems for method that changed from private to @noreference public
Summary: Invalid API problems for method that changed from private to @noreference public
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 212389
  Show dependency tree
 
Reported: 2008-08-20 06:00 EDT by Markus Keller CLA
Modified: 2009-01-15 04:39 EST (History)
2 users (show)

See Also:

Attachments
Proposed fix (10.05 KB, patch)
2008-08-27 15:39 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-08-20 06:00:14 EDT 
M20080813-0800 and I20080812-0800

- check out org.eclipse.ui.navigator from HEAD or R3_4_maintenance
- remove .api_filters file

=> Invalid error:
The method org.eclipse.ui.navigator.NavigatorActionService.getActionProviderInstance(CommonActionProviderDescriptor) is no longer API

The method used to be private in 3.4 but the fix for bug 212389 turned it into:
/**
 * [..]
 * @noreference This method is not intended to be referenced by clients.
 */
public CommonActionProvider getActionProviderInstance([..]
Comment 1 Olivier Thomann CLA 2008-08-27 15:39:33 EDT 
Created attachment 111113 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2008-08-27 19:12:32 EDT 
Released for 3.5M2.
Darin, please verify.
Regression tests added in org.eclipse.pde.api.tools.comparator.tests.FieldDeltaTests#test62
org.eclipse.pde.api.tools.comparator.tests.FieldDeltaTests#test63
org.eclipse.pde.api.tools.comparator.tests.MethodDeltaTests#test85
org.eclipse.pde.api.tools.comparator.tests.MethodDeltaTests#test86
Comment 3 Darin Wright CLA 2008-08-28 10:03:39 EDT 
Verified, added builder regression test:

MethodCompatibilityModifierTests.testPrivateToPublic*()