Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244590 - Automated build is broken
Summary: Automated build is broken
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.1M4   Edit
Assignee: Chris Recoskie CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-19 14:03 EDT by Jason Montojo CLA
Modified: 2011-01-31 08:11 EST (History)
1 user (show)

See Also:


Attachments
Master/composite feature (11.85 KB, application/zip)
2008-08-28 11:42 EDT, Jason Montojo CLA
g.watson: iplog+
Details
Build scripts for the org.eclipse.ptp.master-feature (6.64 KB, application/zip)
2008-08-28 11:48 EDT, Jason Montojo CLA
no flags Details
Build logs (457.13 KB, application/zip)
2008-08-28 15:14 EDT, Jason Montojo CLA
no flags Details
Updated releng scripts (6.64 KB, application/zip)
2008-08-28 16:55 EDT, Jason Montojo CLA
g.watson: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Montojo CLA 2008-08-19 14:03:07 EDT
We need to add the remote builder dependencies to the rdt.map in org.eclipse.ptp.rdt.releng/maps.

I'll post a patch soon that fixes this as soon as I can figure out what all the dependencies are.
Comment 1 Jason Montojo CLA 2008-08-28 10:29:43 EDT
It's actually not as simple as fixing the map files.  Since the remote.core and remote.ui plugins are part of PTP, we need to have them built when making the RDT feature.  The easiest way to get around this is to automate the entire PTP build.

Since the build is done feature-by-feature, we can build and package everything by using a composite feature, similar to what CDT is doing.

I'll post zip files of the composite feature and a new set of releng scripts/maps to make this magic happen.
Comment 2 Greg Watson CLA 2008-08-28 10:42:01 EDT
An automated build of ptp would be very welcome! Let me know if I need to do anything to make it easier.
Comment 3 Jason Montojo CLA 2008-08-28 11:42:33 EDT
Created attachment 111220 [details]
Master/composite feature

This feature is meant to bring together all the features in PTP so that it can be built in an automated way.  So far, the features it covers are:

org.eclipse.ptp-feature
org.eclipse.ptp.core-feature
org.eclipse.ptp.rdt-feature
org.eclipse.ptp.remote-feature

The map file (in the next zip file) will need to be updated as we add more features to this.

This feature needs to live in /org.eclipse.ptp/releng/org.eclipse.ptp.master-feature.  The map file I'm providing assumes this feature lives in that spot in CVS.
Comment 4 Jason Montojo CLA 2008-08-28 11:48:17 EDT
Created attachment 111224 [details]
Build scripts for the org.eclipse.ptp.master-feature

This zip file contains the releng framework for building the PTP master feature.  The way things are set up assumes the build is happening in a Linux environment.  We can easily change things around so that's not the case.  This project doesn't need to be committed in any particular place.

The map file current lists all the plugins required for the following features:

org.eclipse.ptp-feature
org.eclipse.ptp.core-feature
org.eclipse.ptp.rdt-feature
org.eclipse.ptp.remote-feature

As we add the other PTP features to the map file, we'll need to add the corresponding feature to the org.eclipse.ptp.master-feature.  We'll also need to update build.xml so that the right modules in CVS get tagged.  Finally, we'll need to add the dependent plugins and fragments for each new feature to the map file.

The build finishes right now, but there are compile errors for ptp and ptp.core.  I think it's a dependency issue but I haven't had a chance to look deeply to see what's going on.  The RDT and remote features are building properly, though.
Comment 5 Greg Watson CLA 2008-08-28 12:44:14 EDT
Where do the build logs go?
Comment 6 Jason Montojo CLA 2008-08-28 14:42:29 EDT
If you run build.sh, the top-level build logs are sent to stdout and stderr.  Specialized compilation logs are stored in the directory where the finished build is stored.  Relative to build.sh, it's in results/I.I{timestamp}/compilelog.txt.

Right now, I've got the build running on an internal machine.  I can send you the log files if you'd like.  I don't have access to the Eclipse build machine so I can't get it up and running there.
Comment 7 Greg Watson CLA 2008-08-28 14:56:03 EDT
Sure, send me a copy and I'll take a look.
Comment 8 Jason Montojo CLA 2008-08-28 15:09:35 EDT
Urk.  I'll need to post a new zip of the build scripts.  I left some bits commented out while I was testing the build.  It's the part that bootstraps it all.  I'll uncomment and repost the zip.
Comment 9 Jason Montojo CLA 2008-08-28 15:14:59 EDT
Created attachment 111243 [details]
Build logs

build.log is the top level build log.
compilelog.txt is the compilation log.

Based on the order in which the files appear to be compiled, I think the errors are occurring because the org.eclipse.ptp.proxy.protocol plugin is being compiled last.  I'm not sure how to change this... I always assumed the dependencies were computed automatically.
Comment 10 Greg Watson CLA 2008-08-28 16:02:51 EDT
Weird. It's complaining about org.eclipse.debug.core not being resolved, even though it's in the dependency list:

1. ERROR in /home/jmontojo/rdt-build/org.eclipse.ptp.releng/results/plugins/org.eclipse.ptp.debug.core/src/org/eclipse/ptp/debug/core/IPBreakpointManager.java (at line 15)
        import org.eclipse.debug.core.model.IBreakpoint;
               ^^^^^^^^^^^^^^^^^
The import org.eclipse.debug cannot be resolved

I'll need to spend more time looking into this.
Comment 11 Jason Montojo CLA 2008-08-28 16:55:47 EDT
Created attachment 111250 [details]
Updated releng scripts

This version of the releng scripts doesn't have the bootstrap phase commented out.
Comment 12 Chris Recoskie CLA 2008-09-17 13:01:50 EDT
What is the status on this?  Should we mark it fixed?
Comment 13 Vivian Kong CLA 2008-09-17 13:48:29 EDT
We've automated both PTP & RDT build on the Eclipse build server.  I believe Greg still needs to fix up the PTP build a bit more for the TAU component.  Once that's done we can test out the scripts we have for building the RDT server packages automatically.
Comment 14 Vivian Kong CLA 2008-09-22 08:57:45 EDT
We have the server packages building with the PTP build now.
http://wiki.eclipse.org/PTP/builds/2.1
Comment 15 Chris Recoskie CLA 2008-10-07 09:47:15 EDT
I think this is FIXED.