Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244589 - RDT content assist causes NPE when used with plain CDT
Summary: RDT content assist causes NPE when used with plain CDT
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 2.1M2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.1   Edit
Assignee: Chris Recoskie CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-19 14:01 EDT by Jason Montojo CLA
Modified: 2011-05-14 06:36 EDT (History)
0 users

See Also:


Attachments
Proposed patch (2.98 KB, patch)
2008-08-19 14:01 EDT, Jason Montojo CLA
g.watson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Montojo CLA 2008-08-19 14:01:15 EDT
Created attachment 110376 [details]
Proposed patch

When RDT is installed, its content assist contribution interferes with CDT.  This happens because RDT happens to use the same extension points.

The NPE happens because RDT is trying to compute proposals for a CDT project.  Such a project does not have an associated service model configuration.  That missing bit causes the NPE.

The following patch adds a null check for a missing service model configuration.  It also fixes an bogus instanceof check in RemoteCompletionProposalAdapter.getService().
Comment 1 Chris Recoskie CLA 2008-08-19 16:04:06 EDT
Applied to HEAD.  Thanks.