Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244527 - [Net] Assertion in the NetTest.setProxiesEnabled(boolean) method is errorprone
Summary: [Net] Assertion in the NetTest.setProxiesEnabled(boolean) method is errorprone
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-19 06:49 EDT by Pawel Pogorzelski CLA
Modified: 2009-06-02 06:52 EDT (History)
1 user (show)

See Also:

Attachments
Patch (1.02 KB, patch)
2008-08-19 07:06 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2008-08-19 06:49:30 EDT 
Build ID: N20080814-2000

Steps To Reproduce:
1. Make sure system proxy is not supported on the machine
2. Call the method setSystemProxiesEnabled(true) 
3. Call the method setProxiesEnabled(true)
4. The assertion within the setProxiesEnabled(boolean) method breaks

More information:
The assertion breaks because of the wrong assumption on how the method IProxyService.isProxiesEnabled() works. As can be seen in javadocs it returns false when system proxy is enabled (by calling setSystemProxiesEnabled()) but not supported on the platform.
Comment 1 Pawel Pogorzelski CLA 2008-08-19 07:06:37 EDT 
Created attachment 110328 [details]
Patch

Szymon, will you have a look at this?
Comment 2 Szymon Brandys CLA 2008-08-19 07:34:41 EDT 
Looks good. Proceed :-)
Comment 3 Tomasz Zarna CLA 2008-08-19 07:39:30 EDT 
Yes sir. Released, sir.