Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244376 - [Bidi] Text alignment should be consistent with text direction in BIRT Designer
Summary: [Bidi] Text alignment should be consistent with text direction in BIRT Designer
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 2.3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.3.1   Edit
Assignee: Dazheng Gao CLA
QA Contact:
URL:
Whiteboard: Non-Auto
Keywords:
Depends on: 244375
Blocks:
  Show dependency tree
 
Reported: 2008-08-17 13:14 EDT by Lina Kemmel CLA
Modified: 2009-07-09 05:51 EDT (History)
7 users (show)

See Also:

Attachments
Proposed patch (7.37 KB, patch)
2008-08-17 13:23 EDT, Lina Kemmel CLA 		Lina.Kemmel: review?
Details | Diff
Report design for manual test (14.26 KB, application/octet-stream)
2008-08-17 13:48 EDT, Lina Kemmel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lina Kemmel CLA 2008-08-17 13:14:52 EDT 
Build ID: 2_3_1-N20080815

Following https://bugs.eclipse.org/bugs/show_bug.cgi?id=185957#c8,
we need to make text alignment consistent with the text direction in BIRT Designer.

A similar bug was filed against Report Engine: bug 244375.
Comment 1 Lina Kemmel CLA 2008-08-17 13:23:02 EDT 
Created attachment 110167 [details]
Proposed patch

The patch contains a number of pretty trivial changes to link between text
direction and text alignment in report designer GUI, some minor cleanup.
Comment 2 Lina Kemmel CLA 2008-08-17 13:28:17 EDT 
(In reply to comment #1)
> ... in report designer GUI, some minor cleanup.

Sorry, missed a word: 

The patch contains a number of pretty trivial changes to link between text
direction and text alignment in report designer GUI, *and* some minor cleanup.
Comment 3 Lina Kemmel CLA 2008-08-17 13:48:43 EDT 
Created attachment 110171 [details]
Report design for manual test
Comment 4 Zhiqiang Qian CLA 2008-08-18 01:51:35 EDT 
I'm not sure about this change. Is this a requirement to swap the text alignment setting when in RTL direction? Actually from CSS spec, if the "text-align" property is set explicitly, it will always follow the actual setting regardless the direction. Only when "text-align" property is not set, it will use "right" for "RTL" and "left" for "LTR". That being said, if direction is "RTL", text-align is "left", the visual effect for text alignment is still "left".

I think both Firefox and IE follow this rule, if we take a different approach, would it be confusing for user?
Comment 5 Lina Kemmel CLA 2008-08-18 05:56:52 EDT 
This change was supposed to conform to the spec and applies to 2 cases:

(1) when text-align is not set explicitly (and follows text direction); in other words, the default 'text-align' depends now on the text direction - as opposed to the report orientation, as at present,
(2) when text align is set to 'justify' (in such a case the last line follows text direction).

All explicit alignment types (other than 'justify') are visualized identically in both directions.

Sorry for not stressing this point.
Comment 6 Zhiqiang Qian CLA 2008-08-18 06:06:33 EDT 
Ok, I see, so the default text alignment is based on direction property on text item itself, not report design.
Comment 7 Dazheng Gao CLA 2008-08-21 22:41:20 EDT 
UI code need the BidiAlignmentResolver class change, so depend on the 244375.
Comment 8 Dazheng Gao CLA 2008-08-26 04:15:11 EDT 
Fixed.Follow the new engine API.