Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244375 - [Bidi] Text alignment should be consistent with text direction in BIRT engine
Summary: [Bidi] Text alignment should be consistent with text direction in BIRT engine
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 2.3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jun Ouyang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 244376
  Show dependency tree
 
Reported: 2008-08-17 13:02 EDT by Lina Kemmel CLA
Modified: 2008-08-26 03:46 EDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (25.30 KB, patch)
2008-08-17 13:09 EDT, Lina Kemmel CLA
Lina.Kemmel: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lina Kemmel CLA 2008-08-17 13:02:41 EDT
Build ID: 2_3_1-N20080815

Following https://bugs.eclipse.org/bugs/show_bug.cgi?id=185957#c8,
we need to make text alignment consistent with the text direction in BIRT engine.

A similar bug will be filed against Designer.
Comment 1 Lina Kemmel CLA 2008-08-17 13:09:10 EDT
Created attachment 110166 [details]
Proposed patch

The patch contains a number of pretty trivial changes to link between text direction and text alignment during report generation and rendering.
...Plus some minor formatting modifications.
Comment 2 Lina Kemmel CLA 2008-08-17 13:25:36 EDT
The same issue in Report Designer is addressed in bug 244376.
Comment 3 Lina Kemmel CLA 2008-08-17 13:49:43 EDT
Report for a manual test is available here:
https://bugs.eclipse.org/bugs/attachment.cgi?id=110171
Comment 4 Lina Kemmel CLA 2008-08-18 09:40:45 EDT
Comment on attachment 110166 [details]
Proposed patch


Please disregard the changes for HTMLPerformanceOptimize.java in the patch, since they can't be contained in 2.3.1. They were made in course of bug 185957, which will be deferred.

Please let me know if the patch should be re-submitted without these changes.
Comment 5 Jun Ouyang CLA 2008-08-26 03:46:21 EDT
The patch is applied.