Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 244269 - [logview] create preference to control whether logview activates on events
Summary: [logview] create preference to control whether logview activates on events
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Jacek Pospychala CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-15 00:03 EDT by Chris Aniszczyk CLA
Modified: 2008-12-14 21:59 EST (History)
3 users (show)

See Also:


Attachments
patch (7.90 KB, patch)
2008-12-09 06:50 EST, Jacek Pospychala CLA
caniszczyk: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-08-15 00:03:14 EDT
There has been a usecase in RCP applications where people want to use the logview but not have it activate on new events. We should consider creating a preference to control this behavior via plugin_customization.ini or other means.

Something like

org.eclipse.ui.views.log/ACTIVATE_ON_EVENTS or something
Comment 1 Martin Oberhuber CLA 2008-12-03 11:09:55 EST
I think that the Preference should specify the severity level that leads to activating the logview. 

Currently, it activates on any event, regardless of info, warning or error. Users should be able to specify by Preference that the logview activates on Errors only, but not on warnings or info severity. The use-case for this is that plugins may log interesting information as a kind of "tracing" for debugging issues, so the logview should not pop up on such "info" logs. "Error" logs, on the other hand, point to important issues that may explain misbehavior of the program, so the logview should pop up on those.

Should I file a separate defect for this?
Comment 2 Curtis Windatt CLA 2008-12-03 11:28:43 EST
(In reply to comment #1)
> Should I file a separate defect for this?
> 

No, it makes sense for us to support different levels in the preference setting.
Comment 3 Jacek Pospychala CLA 2008-12-03 11:31:23 EST
interesting. 
Comment 4 Jacek Pospychala CLA 2008-12-04 10:07:59 EST
fyi, there's already a preference for activation on new events.
Go to view menu and see "Activate on new events". Property is stored in workspace/.metadata/plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.logs.view.prefs
and property key is activate.
The problem is it doesn't work when I set in plugin_customization.ini:
org.eclipse.ui.logs.view/activate=false

I'm checking out why.
Comment 5 Jacek Pospychala CLA 2008-12-09 06:50:14 EST
Created attachment 119893 [details]
patch

fix current preferences implementation, to correctly read default values.
After this patch is released, one can add following to plugin_customization.init:

org.eclipse.ui.views.log/activate=false

to deactive view by default.
Comment 6 Jacek Pospychala CLA 2008-12-09 06:57:14 EST
(In reply to comment #1)
> I think that the Preference should specify the severity level that leads to
> activating the logview. 
> 
> Currently, it activates on any event, regardless of info, warning or error.
> Users should be able to specify by Preference that the logview activates on
> Errors only, but not on warnings or info severity. The use-case for this is
> that plugins may log interesting information as a kind of "tracing" for
> debugging issues, so the logview should not pop up on such "info" logs. "Error"
> logs, on the other hand, point to important issues that may explain misbehavior
> of the program, so the logview should pop up on those.


I think this kind of logic is reserved for status handling mechanism. That is if error/warning/info is important enough, then developer decides to handle it accordingly - e.g. pup up the error dialog to the user.

Your scenario sounds more like fixing someone else's wrong decision that error did not popped any error dialog.
Comment 7 Chris Aniszczyk CLA 2008-12-14 21:59:26 EST
done.

> 20081214

Thanks Jacek!