Community
Participate
Working Groups
build 20021001 -create a Java working set -expand a project containing more than one child -select one child so that the project is gray checked -close the edit dialog -edit the working set -uncheck the gray checked project ->No elements are checked but the finish button is enabled and no error message is displayed. See also bug 24397
The problem arises if the node has not yet been expanded - need to check my code and platform code
Fixed. Available in builds >= I20021008
Verified fixed in build 20021016
This is not completely fixed: In a structure Project1 folder1 file1 -Create a working set and select file1. ->Project1 and folder1 are gray checked -Collapse folder1 -Uncheck Project1 ->No items are checked yet the finish button is still enabled. If you close the edit dialog and reopen you will get an error message indicating that no items are checked. I fixed this for the ResourceWorkingSetPage. See bug 24397.
The current implementation is due to performance problems when clicking in the UI (it took almost a minute with very large workspaces in slow machines). Your fix will surface those problems again. I have fixed the problem you report here by changing the validation mechanism (see JavaWorkingSetPage.validateInput in JDT UI HEAD.
Performance could only be a problem when a large number of items are checked or gray checked because I now recursively uncheck children when an item is unchecked. I tried this with all children of org.eclipse.ui.workbench and performance is not a problem. Perhaps this would be different when working with Java elements. There was a different problem with my fix which I corrected. Your fix is nice because it's simple. However, I'll keep mine for the time being unless it causes problems.
