Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 243587 - [Patch] 'Create Patch' wizard allows the target folder to be a closed project
Summary: [Patch] 'Create Patch' wizard allows the target folder to be a closed project
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-08 09:48 EDT by Remy Suen CLA
Modified: 2009-06-02 06:52 EDT (History)
1 user (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2008-08-12 04:57 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2008-08-08 09:48:20 EDT 
I20080731-0950

1. Team > Create Patch...
2. In the 'Workspace' text field, type in a path within a closed project like '/b/patch.txt' (assuming project 'b' is closed).
3. Click 'Finish'.
4. An error dialog appears telling me that 'Resource '/b' is not open.'.

!ENTRY org.eclipse.core.resources 4 372 2008-08-08 09:46:02.097
!MESSAGE Resource '/b' is not open.
!STACK 1
org.eclipse.core.internal.resources.ResourceException: Resource '/b' is not open.
	at org.eclipse.core.internal.resources.Project.checkAccessible(Project.java:116)
	at org.eclipse.core.internal.resources.File.create(File.java:119)
	at org.eclipse.team.internal.ccvs.ui.operations.WorkspaceFileDiffOperation.copyFile(WorkspaceFileDiffOperation.java:36)
	at org.eclipse.team.internal.ccvs.ui.operations.FileDiffOperation.execute(FileDiffOperation.java:56)
	at org.eclipse.team.internal.ccvs.ui.operations.CVSOperation.run(CVSOperation.java:81)
	at org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnableContext.java:144)
	at org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.runInWorkspace(JobRunnableContext.java:72)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 Tomasz Zarna CLA 2008-08-08 09:54:46 EDT 
Pawel, could you take a look at it? I remember you did some changes in this area in bug 218017 and bug 214105.
Comment 2 Pawel Pogorzelski CLA 2008-08-12 04:57:06 EDT 
Created attachment 109762 [details]
Patch

Guys, I introduced it fixing bug 214105. Hope should be fine now.
Comment 3 Tomasz Zarna CLA 2008-08-12 09:45:10 EDT 
Patch applied to HEAD.