Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 243475 - Old-style source plugin does not include sources of all plugins from the corresponding feature
Summary: Old-style source plugin does not include sources of all plugins from the corr...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 243472 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-08-07 13:38 EDT by Peter Nehrer CLA
Modified: 2008-08-20 16:39 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch. (5.64 KB, patch)
2008-08-07 13:41 EDT, Peter Nehrer CLA 		aniefer: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Nehrer CLA 2008-08-07 13:38:28 EDT 
I realize that this is more of an enhancement request than a bug...

I'm building a new version of a feature where only a few plugins have actually changed (since the base version). When generating the source feature (with the old-style source plugin), I would like to include sources from all plugins in that feature, even those that were not rebuilt but are picked up from the base. The previous (base) version of the source plugin already contains these sources.

The new style (one source bundle per bundle) does support this in that the source feature will automatically pick up the old versions if a new source bundle wasn't generated (which happens when you don't build the plugin but package the base version of it).
Comment 1 Peter Nehrer CLA 2008-08-07 13:41:53 EDT 
Created attachment 109435 [details]
Proposed patch.

This patch 1). stores the location of a previous version of the source plugin (as it is replaced with a newly generated one), and 2). uses that info to get sources for plugins that are not being built (but are included in the feature).
Comment 2 Curtis Windatt CLA 2008-08-07 13:43:25 EDT 
*** Bug 243472 has been marked as a duplicate of this bug. ***
Comment 3 Andrew Niefer CLA 2008-08-20 16:39:16 EDT 
done in HEAD.  I did change the patch slightly, but strategy is the same.