Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 243422 - Feature with empty required version incorrectly converted to [0.0.0,1.0.0)
Summary: Feature with empty required version incorrectly converted to [0.0.0,1.0.0)
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.4.1   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-07 10:48 EDT by Olivier Thomann CLA
Modified: 2008-08-27 15:18 EDT (History)
4 users (show)

See Also:

Attachments
Fix v01 (1.62 KB, patch)
2008-08-12 12:06 EDT, John Arthorne CLA 		no flags Details | Diff
Regression test using a subset of the JDT update site (3.18 KB, patch)
2008-08-12 12:08 EDT, John Arthorne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2008-08-07 10:48:40 EDT 
This used to work.
I am using the update site http://www.eclipse.org/jdt/ui/update-site.
Comment 1 Olivier Thomann CLA 2008-08-07 10:49:14 EDT 
Same for the AST view that I finally installed using the dropins folder.
Comment 2 Olivier Thomann CLA 2008-08-07 11:10:51 EDT 
This seems to be related to this error:
Cannot find a solution where both Match[requiredCapability: org.eclipse.equinox.p2.iu/org.eclipse.core.runtime/[0.0.0,1.0.0)] and Match[requiredCapability: org.eclipse.equinox.p2.iu/org.eclipse.core.runtime/[3.4.100.v20080714,3.4.100.v20080714]] can be satisfied.

I have plenty of unsatisfied dependencies in the log. I just don't see where org.eclipse.core.runtime/[0.0.0,1.0.0)] is coming from.
Comment 3 Simon Kaegi CLA 2008-08-12 11:28:40 EDT 
Also see comment#12 in bug 239449
Comment 4 John Arthorne CLA 2008-08-12 11:38:47 EDT 
This is a regression caused by Pascal's fix for bug 240121. Since the regression was made in 3.4.x this needs to be fixed for 3.4.1.
Comment 5 John Arthorne CLA 2008-08-12 12:05:57 EDT 
Although reverting the fix for bug 240121 solves the problem, the actual bug is in MetadataGeneratorHelper.getVersionRange. It checks for a null version spec and returns an empty version range. However, it doesn't handle a version of "0.0.0" for required plugins. It then converts this to the range [0.0.0,1.0.0) based on the default "compatible" match rule. I believe the fix is to treat a version of "0.0.0" the same as "null".
Comment 6 John Arthorne CLA 2008-08-12 12:06:29 EDT 
Created attachment 109796 [details]
Fix v01
Comment 7 John Arthorne CLA 2008-08-12 12:08:00 EDT 
Created attachment 109797 [details]
Regression test using a subset of the JDT update site
Comment 8 John Arthorne CLA 2008-08-12 12:10:00 EDT 
Fix and regression test released to HEAD (3.5 stream).
Comment 9 John Arthorne CLA 2008-08-12 13:16:44 EDT 
Fix and regression test backported to 3.4.x.
Comment 10 John Arthorne CLA 2008-08-18 13:50:54 EDT 
Jeff, this is the generator bug fix I was referring to in the p2 call today.