Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 243209 - [ActivityMgmt] NPE in org.eclipse.ui.internal.activities.Identifer prevents menu contributions from showing up
Summary: [ActivityMgmt] NPE in org.eclipse.ui.internal.activities.Identifer prevents m...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 242815 263661 (view as bug list)
Depends on:
Blocks: 244171
  Show dependency tree
 
Reported: 2008-08-05 14:30 EDT by Wayne CLA
Modified: 2009-02-04 14:44 EST (History)
4 users (show)

See Also:

Attachments
Patch to fix the problem. (914 bytes, patch)
2008-08-05 14:40 EDT, Wayne CLA 		eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne CLA 2008-08-05 14:30:01 EDT 
Build ID: I20080617-2000 (Version 3.4.0)

In the code of Identifier.removeIdentifierListener(), only part of the code is guarded aganist NPEs.  When the NPE occurs, menu contributions don't show up.  A patch is attached to fix the problem.
Comment 1 Wayne CLA 2008-08-05 14:40:43 EDT 
Created attachment 109205 [details]
Patch to fix the problem.

ZT0A992AG386B
Comment 2 Remy Suen CLA 2008-08-05 15:38:55 EDT 
Platform/UI, there is also bug 242815 about this.
Comment 3 Eric Moffatt CLA 2008-08-06 16:07:17 EDT 
Thanks Remy, I'll give both to Kim and let here decide...
Comment 4 Kim Horne CLA 2008-08-07 09:20:30 EDT 
*** Bug 242815 has been marked as a duplicate of this bug. ***
Comment 5 Kim Horne CLA 2008-08-14 10:42:30 EDT 
This should probably go in for 3.4.1 as well. 

Fix in HEAD.
Comment 6 Kim Horne CLA 2008-09-18 13:44:03 EDT 
Verified in I20080915-1800
Comment 7 Paul Webster CLA 2009-02-04 14:44:12 EST 
*** Bug 263661 has been marked as a duplicate of this bug. ***