Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 243053 - Tabs added via launchConfigurationTabs cannot be placed after each other
Summary: Tabs added via launchConfigurationTabs cannot be placed after each other
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 223747
  Show dependency tree
 
Reported: 2008-08-04 07:59 EDT by Doug CLA
Modified: 2008-08-12 12:21 EDT (History)
2 users (show)

See Also:

Attachments
A plugin.xml that defines 3 tabs, the second depends on the third, and the third depends on the second (2.28 KB, text/xml)
2008-08-04 07:59 EDT, Doug CLA 		no flags Details
A patch that fixes the issue (5.10 KB, text/plain)
2008-08-04 08:01 EDT, Doug CLA 		Michael_Rennie: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Doug CLA 2008-08-04 07:59:11 EDT 
Created attachment 109060 [details]
A plugin.xml that defines 3 tabs, the second depends on the third, and the third depends on the second

If you contribute 2 tabs to the org.eclipse.debug.ui.launchConfigurationTabs extension point, and then add a placement element such that the second contributed tab is after the first contributed tab, then the tabs do not get ordered correctly. 

In the attachment there are 3 tabs; org.eclipse.wst.xsl.debug.ui.jaxp.tabs.processor is to be placed after a 'normal' tab in the tab group, but then org.eclipse.jdt.debug.ui.javaJRETab is to be placed after org.eclipse.wst.xsl.debug.ui.jaxp.tabs.processor, and  org.eclipse.jdt.debug.ui.javaClasspathTab is to be placed after org.eclipse.jdt.debug.ui.javaJRETab. 

What actually happens is that org.eclipse.wst.xsl.debug.ui.jaxp.tabs.processor get correctly placed, but org.eclipse.jdt.debug.ui.javaClasspathTab and org.eclipse.jdt.debug.ui.javaJRETab just appear at the end of the tab group.
Comment 1 Doug CLA 2008-08-04 08:01:08 EDT 
Created attachment 109061 [details]
A patch that fixes the issue

This patch does the job of placing tabs after each other, even when they are contributed.
Comment 2 Michael Rennie CLA 2008-08-05 17:24:46 EDT 
Thanks for the patch Doug, I will have a look once M1 is past (since we are in the M1 warm-up builds this week).
Comment 3 Michael Rennie CLA 2008-08-12 12:20:16 EDT 
applied patch with minor changes.
Comment 4 Michael Rennie CLA 2008-08-12 12:21:35 EDT 
verified