This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 242978 - ensure consistent behavior for tasks that are not in the task list
Summary: ensure consistent behavior for tasks that are not in the task list
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 3.0.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-03 02:54 EDT by Steffen Pingel CLA
Modified: 2008-08-18 02:49 EDT (History)
2 users (show)

See Also:


Attachments
simple patch (2.59 KB, patch)
2008-08-18 02:48 EDT, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (10.41 KB, application/octet-stream)
2008-08-18 02:48 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2008-08-03 02:54:03 EDT
If a task that is not in the task list is opened from a search result the task editor does not indicate that the task is not in the task list. Suggestions for improvements:

-  Contribute an icon to the header toolbar for adding the task to the task list.
- When the task is activated, display a message in the header of the task editor that prompts the user to add the task to the task list.
- Show an information message in the header when the task is opened.
Comment 1 Mik Kersten CLA 2008-08-04 20:02:28 EDT
Sounds about right to me.  Here's another pass:
1) A toolbar button that shows the Task List icon and a "+" overlay allows the user to add the task to the Task List.  Behavior is that a dialog pops up, suggests that the user expand a query instead.  If the user accepts the dialog, the task is added to the Unmatched container.
2) If the user tries to activate, they are first prompted with (1).  I don't think that we should support activation of tasks that are not in the Task List unless we have a strong use case.
3) Information message can be: "Not in in " + TaskListView.getName() + ", click here to add"
Comment 2 Steffen Pingel CLA 2008-08-04 21:23:06 EDT
> 2) If the user tries to activate, they are first prompted with (1).  I don't
> think that we should support activation of tasks that are not in the Task List
> unless we have a strong use case.

I agree. The same should apply to scheduling a task. I am okay with automatically adding the task to Uncategorized which seems less invasive than a dialog.
Comment 3 Mik Kersten CLA 2008-08-04 21:39:17 EDT
(In reply to comment #2)
> I am okay with
> automatically adding the task to Uncategorized which seems less invasive than a
> dialog.

+1.

I assume that without the dialog, this means that we'll disable the Activate button?
Comment 4 Steffen Pingel CLA 2008-08-04 22:15:03 EDT
I would like to keep the enabled activation button. The only change would be that activating a task that is not in the task list would automatically add it to the Uncategorized category.
Comment 5 Mik Kersten CLA 2008-08-04 22:29:27 EDT
There are some bad implications for having the button enabled, arising from the fact that the Task List is the canonical source of all tasks that the user has worked on.  For example, facilities such as the task activation history, or extensions of Mylyn that support planning, could fail if they expected all tasks worked on to be in the Task List.  Unless there is a strong use case for supporting this, and I do not recall seeing it requested, I think that we should adhere to the following design:

	All tasks worked on by the user (i.e., activated) are present in the Task List, 
	unless they have been explicitly deleted by the user.  If they have been deleted 
	by the user, we should consider deleting the record of those tasks from 
	historical traces (e.g. task activity history).
Comment 6 Steffen Pingel CLA 2008-08-04 23:13:51 EDT
I agree with your point. It just seems to be a matter of how the task gets into the task list.

My use-case is that I frequently activate tasks opened from search results and I would rather make that a one click operation than three steps: adding the task to the task list, refresh the editor, activate the task. The editor refresh is my biggest concern: It has to be closed and reopened in order to add the planning and context tab which will make the operation slow.
Comment 7 Mik Kersten CLA 2008-08-12 13:40:31 EDT
Per the discussion on the call, let's support this use case by automatically adding the task to the Uncategorized container.  Let's add the following info message on the header along the lines of:

	"Task added to the Uncategorized container"

Comment 8 Steffen Pingel CLA 2008-08-18 02:48:35 EDT
Created attachment 110197 [details]
simple patch
Comment 9 Steffen Pingel CLA 2008-08-18 02:48:38 EDT
Created attachment 110198 [details]
mylyn/context/zip
Comment 10 Steffen Pingel CLA 2008-08-18 02:49:06 EDT
Patch applied. Rob, please review the changes to TaskActivityManager.