Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 242633 - Undo change done in bug 238624
Summary: Undo change done in bug 238624
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.0.1   Edit
Assignee: Kathy Chan CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-30 17:03 EDT by Troy Bishop CLA
Modified: 2009-02-11 22:03 EST (History)
3 users (show)

See Also:
david_williams: pmc_approved+
kathy: pmc_approved? (raghunathan.srinivasan)
kathy: pmc_approved? (naci.dai)
deboer: pmc_approved+
kathy: pmc_approved? (neil.hauge)
kathy: pmc_approved? (kaloyan)

Attachments
patch (1.75 KB, patch)
2008-07-30 17:31 EDT, Kathy Chan CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Bishop CLA 2008-07-30 17:03:36 EDT 
Build ID: WTP 3.0.1

Steps To Reproduce:
It was found that there needs to be a direct dependency between org.eclipse.jst.ws.consumption to org.eclipse.jface for both UI and headless cases because the org.eclipse.jface plug-in contains non-UI code which the org.eclipse.jst.ws.consumption plug-in requires.  As a consequence we get NoClassDefFoundErrors/ClassNotFoundExceptions for classes that exist in the jface plugin.  Therefore, please undo the change in bug 238624 so that this problem can be resolved.

More information:
Comment 1 Kathy Chan CLA 2008-07-30 17:31:07 EDT 
Created attachment 108789 [details]
patch
Comment 2 Kathy Chan CLA 2008-07-30 17:37:24 EDT 
There seems to be an PDE bug where JFace is listed as an unused dependency even when it's actually required (there's no compile error even after removing the dependency). I'll open a bug later on.

I've put the dependency back with this patch.

I've also undo changes done in bug 238629 where JFace has been listed as optional dependency.

Note that the problem Troy reported is only found in headless environment.

We would attempt to clean up the dependency later on in WTP 3.1.

Problem summary:

Headless product depending on Web services plugins failed to run because the required JFace dependency is not specified.

Changes done:

Put back the JFace dependencies which we have removed or made optional recently.

Reviewed by Yen.

Yen has done testing with the headless product and the problems caused by the recent changes have been fixed.

PMC, please approve for WTP 3.0.1.
Comment 3 Tim deBoer CLA 2008-07-30 17:43:56 EDT 
Approved.
Comment 4 David Williams CLA 2008-07-30 17:47:37 EDT 
The issue in PDE _might_ not be a bug ... but, might be that an extension in plugin.xml ends up requiring it? 

In either case, another thing that would help is if we learned how to use PDE "pre-defined target" setting. This, basically, just defines a subset of your larger target. This then would make it easier to test/compile against a "headless" environment. 

How about it Troy ... sounds like it might be worth your while to contribute a pre-defined target! :)
Comment 5 Kathy Chan CLA 2008-07-30 19:33:53 EDT 
Patch released to HEAD and R3_0_maintenance as v200807302152.
Comment 6 Kathy Chan CLA 2008-10-27 14:17:51 EDT 
This defect has been in resolve state for a while.  Please verify this with the appropriate WTP driver which can be found in:

http://download.eclipse.org/webtools/downloads/

We would verify and close the defect on the originator's behalf if it has not been verified 2 weeks after it's been changed to Verified state.
Comment 7 Troy Bishop CLA 2008-10-27 14:38:29 EDT 
Verified in adaptor tool building on top of WTP 3.0.1.
Comment 8 Kathy Chan CLA 2009-02-11 22:03:52 EST 
Closing defects in verify states.