Community
Participate
Working Groups
The test suite has a number of failing tests that need to be updated.
Created attachment 109019 [details] Patch for RepositoryReportFactoryTest
Created attachment 109020 [details] mylyn/context/zip
Created attachment 109103 [details] updated Patch actually I fixed the followings files BugzillaSearchEngineTest BugzillaConfigurationTest AllBugzillaTests RepositoryReportFactoryTest BugzillaRepositoryConnectorTest2 BugzillaProductParserTest What I need to know is how should I remove the "new BugzillaTask"? Can I use TasksUi.getRepositoryModel().createTask() ? This is used in TaskListNotificationManagerTest
Created attachment 109104 [details] mylyn/context/zip
Frank, this is awesome that you are hacking on this! This is a really critical task and if you have more time for it great! As for task creation, TasksUi.getRepositoryModel().createTask() should do the trick.
(patch applied and ip log updated)
Created attachment 109461 [details] patch of BugzillaTaskListManagerTest Here my patch for BugzillaTaskListManagerTest For TaskListNotificationManagerTest I need some help.
Created attachment 109462 [details] mylyn/context/zip
Patch applied, IP log updated. (In reply to comment #7) > For TaskListNotificationManagerTest I need some help. Just leave this test for last if you can Frank.
Created attachment 109833 [details] 3. patch now included fixes for EncodingTest testDifferentReportEncoding testProperEncodingUponPost TaskEditorTest testAccessNewEditor testinitializeTaskData In TaskListStandaloneTest I found the following problem. task.isPastReminder() returns an other value then TasksUiPlugin.getTaskActivityManager().isPastReminder(task) This was the change from TaskActivityManager Version 1.60 || !task.getScheduledForDate().isDay() was insert in the if statment. What is to do for this?
Created attachment 109834 [details] mylyn/context/zip
(In reply to comment #10) > Created an attachment (id=109833) > 3. patch > > now included fixes for > > EncodingTest > testDifferentReportEncoding > testProperEncodingUponPost > TaskEditorTest > testAccessNewEditor > testinitializeTaskData > > > In TaskListStandaloneTest I found the following problem. > > task.isPastReminder() returns an other value then > > TasksUiPlugin.getTaskActivityManager().isPastReminder(task) > > This was the change from TaskActivityManager Version 1.60 > > || !task.getScheduledForDate().isDay() was insert in the if statment. > > What is to do for this? Greate Frank. Patch applied, ip log updated. Regarding your question, I'll need to fix this discrepancy and eliminate all use of the old api. For tests if you could use the new api that would be ideal.
(In reply to comment #12) > (In reply to comment #10) > > Created an attachment (id=109833) > > 3. patch > > > > now included fixes for > > > > EncodingTest > > testDifferentReportEncoding > > testProperEncodingUponPost > > TaskEditorTest > > testAccessNewEditor > > testinitializeTaskData > > > > > > In TaskListStandaloneTest I found the following problem. > > > > task.isPastReminder() returns an other value then > > > > TasksUiPlugin.getTaskActivityManager().isPastReminder(task) > > > > This was the change from TaskActivityManager Version 1.60 > > > > || !task.getScheduledForDate().isDay() was insert in the if statment. > > > > What is to do for this? > > Greate Frank. Patch applied, ip log updated. Regarding your question, I'll need > to fix this discrepancy and eliminate all use of the old api. For tests if you > could use the new api that would be ideal. Rob, what is the expected Result of isPastReminder for the given Sourcecode AbstractTask task = new LocalTask("1", "1"); task.setScheduledForDate(new DateRange(Calendar.getInstance())); old API return true new API return false
Created attachment 110394 [details] update Here the not fixed problems from AllBugzillaTests 1 Error; 6 failure TaskListNotificationManagerTest testTaskListNotificationIncoming (failure) testTaskListNotificationQueryIncoming (failure) testTaskListNotificationQueryIncomingRepeats (failure) BugzillaTaskTest testCompletionDate (error) BugzillaTaskDataHandlerTest warning (failure) TaskListStandaloneTest testOrphanedTasks (failure) testOrphanedQueries (failure) Please can somon give me some information how to fix this or do the remaining work.
Created attachment 110395 [details] mylyn/context/zip
(In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #10) > > > Created an attachment (id=109833) > > > 3. patch > > > > > > now included fixes for > > > > > > EncodingTest > > > testDifferentReportEncoding > > > testProperEncodingUponPost > > > TaskEditorTest > > > testAccessNewEditor > > > testinitializeTaskData > > > > > > > > > In TaskListStandaloneTest I found the following problem. > > > > > > task.isPastReminder() returns an other value then > > > > > > TasksUiPlugin.getTaskActivityManager().isPastReminder(task) > > > > > > This was the change from TaskActivityManager Version 1.60 > > > > > > || !task.getScheduledForDate().isDay() was insert in the if statment. > > > > > > What is to do for this? > > > > Greate Frank. Patch applied, ip log updated. Regarding your question, I'll > need > > to fix this discrepancy and eliminate all use of the old api. For tests if you > > could use the new api that would be ideal. > > Rob, > what is the expected Result of isPastReminder for the given Sourcecode > AbstractTask task = new LocalTask("1", "1"); > task.setScheduledForDate(new DateRange(Calendar.getInstance())); > old API return true > new API return false false is correct since this the DateRange isn't for a specific day in this case. I'll address this on bug#244092. Then more of these notification tests should fall into place.
Patch applied, ip log updated.
Update: 75/75 test are now passing. Thanks for all the help here Frank. Are you interested in continuing with porting the rest of the old BugzillaRepositoryConnectorTest tests to the new class? There are a few remaining that might be good to have running.
(In reply to comment #18) > Update: 75/75 test are now passing. Thanks for all the help here Frank. Are you > interested in continuing with porting the rest of the old > BugzillaRepositoryConnectorTest tests to the new class? There are a few > remaining that might be good to have running. Yes, I can do this. Is there a List of tests that I should port to the new class or should I port all remaining tests.
(In reply to comment #19) > Yes, I can do this. Is there a List of tests that I should port to the new class > or should I port all remaining tests. Tests that should be tasks framework level tests (i.e. that simply test state changes incoming/outgoing/synchronized) can likely be ignored and flagged for moving into a tasks unit test if not covered already. Other bugzilla specific tests such as attachments, time submission, etc would be great to have ported. If a test is ambiguous, just fire me an email Frank and I'll get back to you asap.
Created attachment 118767 [details] some more tests
Created attachment 118768 [details] mylyn/context/zip
.
Merged BRCTest2 all back into BRCTest.java. Tests remaining to port appended to bottom of file.
Created attachment 121435 [details] attachment tests after apply patch (attachment ID 121363) from bug#208839 comment#5 you can do this patch to add more tests.
Created attachment 121436 [details] mylyn/context/zip
(In reply to comment #26) > Created an attachment (id=121435) > attachment tests > > after apply patch (attachment ID 121363) from bug#208839 comment#5 you can do > this patch to add more tests. Patch applied, ip log updated.
Is there anything left to do here? Otherwise I would suggest closing the bug and adding additional tests as we move along.
(In reply to comment #29) > Is there anything left to do here? Otherwise I would suggest closing the bug and > adding additional tests as we move along. There are tests that need some work - testSynchronize old code is commented out - testTimeTracker222 and testTimeTracker218 - testSynchChangedReports I did not know how important this is and if it is OK to do this an an new bug.
Created attachment 122586 [details] fix for failing test
(In reply to comment #30) > - testTimeTracker222 and testTimeTracker218 > - testSynchChangedReports Yes, I'd like to have these ported before we mark this one resolved.
Created attachment 123641 [details] patch for last three tests What is the replace of "assertFalse(taskData4.isStale());" I need this for finish testSynchChangedReports.
Created attachment 123642 [details] mylyn/context/zip
The connector invokes session.markStale(task); in preSynchronization(). you can check if a task ist stale using session.getStaleTasks().contains(task).
Created attachment 123646 [details] updated patch comment#33 included in this patch
Created attachment 123647 [details] mylyn/context/zip
Excellent! Patch applied, ip log update.
*** Bug 237212 has been marked as a duplicate of this bug. ***
