Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 242341 - PDE import the files into an incorrect folder
Summary: PDE import the files into an incorrect folder
Status: RESOLVED DUPLICATE of bug 245565
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-29 04:27 EDT by Meng Xin Zhu CLA
Modified: 2008-11-19 09:44 EST (History)
4 users (show)

See Also:


Attachments
the source code of sample plug-in (6.43 KB, application/zip)
2008-11-19 00:16 EST, Meng Xin Zhu CLA
no flags Details
Screenshot of fixed import (5.96 KB, image/png)
2008-11-19 09:42 EST, Curtis Windatt CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Meng Xin Zhu CLA 2008-07-29 04:27:41 EDT
Build ID: I20080530-1730

Steps To Reproduce:
1.one plug-in has below structure,
--com.ibm.example
 |--src
   |--icons
 |--icons
2.import 'com.ibm.example' plug-in by File - Import - Plugin and fragments
3.the folder 'icons' under root can't be imported correctly, all those files are imported into the 'icons' under src


More information:
If two icons folders have different name, both of them can be imported correctly.
Comment 1 Curtis Windatt CLA 2008-11-18 14:23:49 EST
I couldn't reproduce the problem, but I'm unsure of the structure of your plug-in.  If you attach an example plugin I will look at it again.

A couple of notes:

1) Plugin import does not support embedded source, so a plug-in that contains class files and java source cannot be imported as source.  The source must be packaged in the proper source bundles (http://wiki.eclipse.org/Source_Bundles).  To package source properly you must use PDE Build (we are looking at how to do this from the UI).

2) If you are developing out of a folder named src/, even though your compiled files may be compiled to bin/, they will be placed at the root of the source jar.  So, depending on the setup of your build.properties, you will end up with icons folders at the root of both the source and binary plugins.  There is no way for us to know on import that one icon folder should be nested.

Comment 2 Chris Aniszczyk CLA 2008-11-18 18:05:57 EST
works for me also
Comment 3 Meng Xin Zhu CLA 2008-11-19 00:16:55 EST
Created attachment 118217 [details]
the source code of sample plug-in
Comment 4 Meng Xin Zhu CLA 2008-11-19 00:26:11 EST
I still consider it's a bug. Pls try below steps,

1. unpackage above attachment into a folder, such as 

zip test.zip -d ~/tmp

2. launch your eclipse, then import plug-ins and fragment, uncheck the target platform, select ~/tmp as plug-in location, and check 'projects with source'

3. add 'com.ibm.test' plug-in into list, then import it

4. pls the files after finishing the import opertation

the file icons/sample.gif under the plug-in's root is imported into wrong place, which is used the actionSet extension. It's imported into src/icons folder! That's wrong.
Comment 5 Curtis Windatt CLA 2008-11-19 09:42:46 EST
Created attachment 118252 [details]
Screenshot of fixed import
Comment 6 Curtis Windatt CLA 2008-11-19 09:44:51 EST
I reproduced with the sample plugin.  Fortunately, the problem will be fixed by my changes to bug 245565, see the attached screenshot.  Marking as a duplicate.

*** This bug has been marked as a duplicate of bug 245565 ***