Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 242310 - TaskKey CommitTemplateVariable should not use the task id
Summary: TaskKey CommitTemplateVariable should not use the task id
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.2   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-28 18:44 EDT by Shawn Minto CLA
Modified: 2008-10-18 10:37 EDT (History)
2 users (show)

See Also:

Attachments
patch (2.68 KB, patch)
2008-07-28 19:09 EDT, Shawn Minto CLA 		no flags Details | Diff
mylyn/context/zip (19.05 KB, application/octet-stream)
2008-07-28 19:09 EDT, Shawn Minto CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2008-07-28 18:44:26 EDT 
If the connector says that the task key is null, this normally would mean that the key is obscure and should never be shown to users.  This means that in the commit templates the TaskKey CommitTemplateVariable should not default to the id if the key is not provided.
Comment 1 Shawn Minto CLA 2008-07-28 19:09:57 EDT 
Created attachment 108581 [details]
patch

Attached is a patch that does not default to the task id for the task key variable.
Comment 2 Shawn Minto CLA 2008-07-28 19:09:59 EDT 
Created attachment 108582 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2008-08-03 23:26:09 EDT 
Thanks for the fix and test case Shawn! Fixed in >I20080803-0500.