Community
Participate
Working Groups
As part of the PDE incubator, I explored refactoring out the user assistance code from PDE. This is now almost complete and we will need to make the move. http://wiki.eclipse.org/PDE/Incubator/UA
I will open bugs against releng to notify them of this. We will have to add these plug-ins to the PDE feature.
Nice & useful job, Chris!
Now I just need to find a new owner for User Assistance in PDE :)
Well, obviously, I'd be pleased to be this owner :)
(In reply to comment #4) > Well, obviously, I'd be pleased to be this owner :) That's excellent! Do you want to help finish the refactoring? I need help getting the images refactored out... currently org.eclipse.pde.ua.ui has some deps on PDEPluginImages... we need to have our own registry and minimize the dependencies on PDE UI :) Let me know if you can do this, otherwise I will march on to after I'm done my NLS (about 95% done with this)
Of course I can help. I will finish the job wrt the UA image registry!
(In reply to comment #6) > Of course I can help. I will finish the job wrt the UA image registry! Ben, as soon as you have the base code for the image registry, I suggest you post it here as we can do this work in tandem possibly. It wasn't really fun doing all the NLS stuff so maybe we can do this together to make things move faster. After that is done, the next step will be to get a patch against pde core/ui to remove all UA related things and make sure the new plug-ins work seamlessly. I will work on creating a new bugzilla category for User Assistance amongst other things.
I'll attach the patch regarding the image registry ASAP, but it'll probably be sometime in the week-end. np for a tandem work :)
Thanks!
Way too much sun during the weekend... :op I'll do my best to tackle it in the coming days...
This will happen in M2, not enough time for M1
Chris, I don't forget I've got to tackle this... :) BTW, do you mind setting the same code formatting, errors, etc. rules than in the other PDE plug-ins? Perhaps you can set autoformat on save too (I don't remember if it's the case with others o.e.pde.*...)?
ok, I will set the settings later today after lunch and reformat the whole thing. I was also going to add the wizards in the plugin.xml. Have you made any progress that I may hurt by doing these changes?
You can make the changes ; I have some work in progress but nothing that will be impacted by your changes.
I'm on holiday so I guess I'll have the time to work on this, at last! Expect my patches in the days to come, I promise :)
Fantastic Benjamin, once you post a patch, I can help you along with the painful process. We will target this for M3!
Chris, could you please tell me how much time do I have before M3? I really don't forget it, but I've got the head under water right now :-/ The real pity is I have some significant outgoing changes...
We have about 2 weeks. Let me know when you're ready for the fun :)
To do this for M3, it really needs to be done as early as possible next week (Oct 20-22nd). If it is ready by Tuesday we should discuss it at the PDE call. Waiting any longer than that risks causing releng headaches during the warmup/milestone builds.
agreed, it's getting late in the game. However, we can drop this early in M4.
Created attachment 115523 [details] refactoring, refactoring, refactoring here is my incoming missile * UA icons moved into the UA-UI plug-in * UA editors & wizards (cheatsheets, ctxhelp, toc) now totally live in UA-UI (removed from both PDE UI plugin.xml and sources) * refactoring on the way code-folding was computed on PDE source pages * PDE UI messages.properties & NLS class cleaned off of any "UA" entry At the moment, there are a lot of warnings due to heavy usage of internal PDE UI code (I've added some x-friends clauses, btw, more or less the same that were already there for DS UI): we have a lot of work to make PDE UI much more extensible (incoming PITA ;-) )
Created attachment 115524 [details] actual content of the pde.ua.ui/icons folder I intentionnaly only kept the entries relative to the deletion of icons in pde.ui in my previous patch, and here are the "new" icons in PDE UA UI. Hope it'll be OK
Created attachment 115525 [details] updated patch Corrected an error caused by missing wizard banner resources for ctxhelp & toc new wizards (i'll file a new bug) I forgot to tell I also updated the pde.ui.tests project to remove the cheatsheet model tests which now live in ua.ui.tests
Created attachment 115526 [details] icons/ folder of pde.ua.ui
Created attachment 115626 [details] updated patch (again) I made a mistake deleting the page_obj.gif in pde.ui ... Sorry ...
Thanks Ben. The patch will go in first week of M4.
Chris, if something goes wrong when applying this patch against HEAD, just tell me and I'll help making a new one
Created attachment 119097 [details] org.eclipse.pde.patch An updated patch.
FYI all, refactoring is done in CVS HEAD. Thanks to everyone who helped PDE do some necessary house cleaning. I created bug 256995 for the final releng issues. Once that is done, I'll close this bug.
done. > 20091201
