Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 240237 - Update director in build only with milestones
Summary: Update director in build only with milestones
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-09 17:13 EDT by DJ Houghton CLA
Modified: 2008-07-23 15:02 EDT (History)
3 users (show)

See Also:

Attachments
patch (6.14 KB, patch)
2008-07-23 14:55 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2008-07-09 17:13:09 EDT 
Currently the build process uses the director application that is built to provision the different builds. This can be error-prone if there are problems with the director, and ultimately the build will fail miserably.

We should modify this process so the director application is only updated at the same frequency as the base-builder. (e.g. only with milestone builds)
Comment 1 Kim Moir CLA 2008-07-17 14:42:07 EDT 
The following bundles will need to be added to basebuilder so the director can be run.  I assume the ones from 3.4 are sufficient?

org.eclipse.core.databinding
org.eclipse.core.databinding.beans
org.eclipse.equinox.p2.console
org.eclipse.equinox.p2.director
org.eclipse.equinox.p2.director.app
org.eclipse.equinox.p2.engine
org.eclipse.equinox.p2.exemplarysetup
org.eclipse.equinox.p2.garbagecollector
org.eclipse.equinox.p2.touchpoint.eclipse
org.eclipse.equinox.p2.touchpoint.natives
org.eclipse.equinox.simpleconfigurator
org.eclipse.equinox.simpleconfigurator.manipulator
org.eclipse.jface
org.eclipse.jface.databinding
org.eclipse.rcp
org.eclipse.ui
org.eclipse.ui.workbench
org.sat4j.core
org.sat4j.pb

I'll attach a patch for the remaining changes to the run.xml.
Comment 2 John Arthorne CLA 2008-07-17 15:51:59 EDT 
Why do we need JFace/databindings/UI?
Comment 3 Kim Moir CLA 2008-07-17 15:59:20 EDT 
I just used all the bundles in the org.eclipse.equinox.p2.director.feature.
The ui oriented ones can probably be left out from basebuilder since the build is headless.
Comment 4 Pascal Rapicault CLA 2008-07-17 16:06:05 EDT 
Make sure to get the ECF bundles as well.
Comment 5 Kim Moir CLA 2008-07-17 16:45:14 EDT 
Yes, the ECF bundles are already there, the new ones I listed are only a delta.
Comment 6 Kim Moir CLA 2008-07-23 14:55:39 EDT 
Created attachment 108254 [details]
patch

test build successful, released for next build.
Comment 7 Kim Moir CLA 2008-07-23 15:02:18 EDT 
closing, fixed for N20080723-2000.