Community
Participate
Working Groups
Use case: copy email address of a commenter to add him on CC to another bug. Have not found any way to do this. Was looking for right-click and context menu e.g. in the outline view or the CC box.
Created attachment 107005 [details] patch this patch is not finished. ToDo is to generate an copy EmailAdress gif and change
Created attachment 107006 [details] mylyn/context/zip
Created attachment 120880 [details] updated patch This is the updated version of patch from comment#2
Created attachment 120881 [details] mylyn/context/zip
Created attachment 121744 [details] screenshot
Thanks for the patch Frank. I find that the additional icon looks a bit noisy for an operation that I would expect to get used infrequently. Maybe a context menu on the comment header if that is possible would work better in this case?
Created attachment 122021 [details] updated patch I implement the using Command Click to copy the mal adress. Is this OK?
Created attachment 122022 [details] mylyn/context/zip
That's an interesting approach. I am afraid though the copy action would be very hard to discover. I have put this on the agenda for the next conference call to gather some ideas how to do the user interaction.
(In reply to comment #9) > That's an interesting approach. I am afraid though the copy action would be > very hard to discover. I have put this on the agenda for the next conference > call to gather some ideas how to do the user interaction. > What's about to change the tooltip text from "emailadress" to "use command + click to copy \"emailadress\" to the clipbord"
Mik suggested to add a chevron to the reply button, similar to the task list working set chooser or the Run toolbar button in Eclipse. That way the editor would still only show a single button per comment which would default to Reply but other actions would be easily discoverable. What do you think about that Frank?
With bug 203798 appear to be fixed, why don't you use object contribution for this? There are other useful actions could be added comment text and/or commenter email.
Created attachment 122989 [details] chevron.gif put this file in org.eclipse.mylyn.tasks.ui.icons.etool16
Created attachment 122991 [details] path with chevron see comment#11
Created attachment 122992 [details] mylyn/context/zip
That's great stuff! I think we should keep the reply action like it is now and add the chevron that you implemented next to it. That way, the frequently used reply action is accessible through a single click and additional actions can be contributed to the popup menu.
Created attachment 123801 [details] updated patch with chevron reply hyperlink is now between title and chevron
Created attachment 123802 [details] mylyn/context/zip
Created attachment 123852 [details] implementation that uses toolbar instead of hyperlink Great work Frank. I have modified your patch slightly to use a toolbar instead of hyperlink. It looks reasonable on GTK/Linux and I find that it has slighlty better user interaction. Leo, could you apply this patch on Carbon and Cocoa to check if it also works on Mac?
(In reply to comment #19) > Created an attachment (id=123852) > implementation that uses toolbar instead of hyperlink > > Great work Frank. I have modified your patch slightly to use a toolbar instead > of hyperlink. It looks reasonable on GTK/Linux and I find that it has slighlty > better user interaction. > > Leo, could you apply this patch on Carbon and Cocoa to check if it also works on > Mac? I dit the test on Carbon and Cocoa both wit 3.5M4 and find that this looks much better.
Thanks a lot Frank! I'll do some clean up of the patch and apply it.
I have committed a new implementation that uses a toolbar and registers an extensible popup menu with the workbench. I still need to externalize the strings once we have agreed on labels and actions that should be contributed to the menu.
(In reply to comment #22) > I have committed a new implementation that uses a toolbar and registers an > extensible popup menu with the workbench. I still need to externalize the > strings once we have agreed on labels and actions that should be contributed to > the menu. COMMENT_CHEVRON and COMMENT_CHEVRON_TOOLTIP is not used and can be removed.
Code cleaned up, reply action added to menu and copy action renamed to "Copy User ID" as per disussion on today's call.
