Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 238950 - P2 Shared Installations - Target Platform Dropins missing
Summary: P2 Shared Installations - Target Platform Dropins missing
Status: RESOLVED DUPLICATE of bug 235336
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL: http://ekkes-corner.blogspot.com/2008...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-30 05:33 EDT by ekkehard gentz CLA
Modified: 2008-08-12 03:32 EDT (History)
2 users (show)

See Also:


Attachments
installed software includes dropins (176.32 KB, image/png)
2008-07-02 18:56 EDT, ekkehard gentz CLA
no flags Details
target platform has no knowledge of bundles from plugins (159.74 KB, image/png)
2008-07-02 18:59 EDT, ekkehard gentz CLA
no flags Details
all works well if not P2 - shared installation (93.41 KB, image/png)
2008-07-02 19:01 EDT, ekkehard gentz CLA
no flags Details
directory structure e34pool (33.30 KB, image/png)
2008-07-03 09:55 EDT, ekkehard gentz CLA
no flags Details
p2installer.ini (19.24 KB, image/png)
2008-07-03 10:00 EDT, ekkehard gentz CLA
no flags Details
bundleLocation (32.93 KB, image/png)
2008-07-03 10:03 EDT, ekkehard gentz CLA
no flags Details
bundle.info (65.71 KB, text/plain)
2008-07-03 10:39 EDT, ekkehard gentz CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description ekkehard gentz CLA 2008-06-30 05:33:01 EDT
Build ID: 3.4

Preferences -> PDE -> Target Platform

If you're using a shared installation the bundles from your dropins are missing !
You only see all bundles from pool (and there you are seeing too much see Bugzilla 238949) and you dont see the bundles from your dropins.

workaround:
The only way to change this is using Add.. for all plugins folders inside your dropins. If you have structured your dropins, this means you have to select each plugins folder from there. It can happen easily to forget something or loosing the overview.

btw: using stand-alone installations all dropins were recognized as expected
Comment 1 Chris Aniszczyk CLA 2008-07-02 17:35:12 EDT
Do bundles exist in the bundles.info (p2 metadata)?
Comment 2 Chris Aniszczyk CLA 2008-07-02 17:39:57 EDT
Ekkehard, are you aware of how the new target platform preference works?

http://mea-bloga.blogspot.com/2008/04/new-target-platform-preference.html
Comment 3 ekkehard gentz CLA 2008-07-02 18:52:18 EDT
hi chris,

yes, I'm aware of how the target platforms work now.
all works well if I'm using 'normal' installations.

But if I'm using P2Installer, install SDK as shared using a bundle pool

then the target platform gives me no way to get the bundles from the dropins folder.

some screenshots follow to demonstrate

and yes: the bundles.info shows the bundles from dropins
Comment 4 ekkehard gentz CLA 2008-07-02 18:56:28 EDT
Created attachment 106368 [details]
installed software includes dropins

here you see the installed software
the openArchitectureWare plugins are from dropins folder and correctly recognized
Comment 5 ekkehard gentz CLA 2008-07-02 18:59:39 EDT
Created attachment 106369 [details]
target platform has no knowledge of bundles from plugins

here you see the target platform
there are only the bundles available from the bundle pool
(as described in bug 238949 here are ALL bundles from bundle pool,
not only the bundles installed in current running application)

checkbox selected or not doesnt matter
of course tried all combinations of apply, reload etc
Comment 6 ekkehard gentz CLA 2008-07-02 19:01:51 EDT
Created attachment 106370 [details]
all works well if not P2 - shared installation

here you see the same scenario but using a normal install,
not via P2 Installer - shared

then all dropins are known and also the bundles from the current running eclipse

the problem isn only using shared installations
Comment 7 Darin Wright CLA 2008-07-02 20:34:19 EDT
We would like to re-work the way target platforms are discovered in 3.5. (I'm not sure we have a bug/feature open for this yet, but it is mentioned on the PDE planning wiki: http://wiki.eclipse.org/PDE/Ideas#Target_Management)

Essentially, we want to use a new API provided by p2 or the runtime that lets use reflection on an installation to see what bundles are installed. This should help reduce these sorts of problems.
Comment 8 ekkehard gentz CLA 2008-07-03 01:46:29 EDT
Darin,

I read about the ideas for target platform management -
the greatest thing for me would be to have more then one target platform in a workspace. then I could simplify my installations of workspaces, which esp. important for use of Mylyn tasks, whats difficult with more then one workspace.

does it mean that at the moment the behaviour with shared installations (only knowing all bundles from all shared applications, but not knowing the bundles from dropins and current installation) is a "feature" of 3.4 and not a bug ?

then I would revert to single installations until 3.5 because the comfort on the one side with using a bundle pool is less worth then the comfort of automagically scanning dropins and haveing my own application as host.

ekke
Comment 9 Darin Wright CLA 2008-07-03 09:39:47 EDT
In your example, is the "e34pool" directory an "root install directory" that contains a "configuration" directory? If so, then this is a bug.

However, if this is the bundle pool location, to which two (or more) configurations point, then this is not a bug. You should be able to point to an install location, and the "configruation" area will tell PDE which bundles from the pool are installed in each installation.
Comment 10 ekkehard gentz CLA 2008-07-03 09:55:17 EDT
Created attachment 106432 [details]
directory structure e34pool

as you can see, e34pool is a root directory
I created only this directory, then P2 Installer fills this bundle pool location with content
Comment 11 ekkehard gentz CLA 2008-07-03 10:00:10 EDT
Created attachment 106433 [details]
p2installer.ini

p2installer.ini was modified and points to a local file:
.../e34p2installer/sdk-installer.properties
Comment 12 ekkehard gentz CLA 2008-07-03 10:03:58 EDT
Created attachment 106434 [details]
bundleLocation

.../e34p2installer/sdk-installer.properties
only thing modified was:
eclipse.p2.bundleLocation pointing to the root of e34pool
Comment 13 Darin Wright CLA 2008-07-03 10:14:45 EDT
In the "configuration" directory is there an "org.eclipse.equinox.simpleconfigurator" directory containing a "bundles.info" file? and does that file contain entries from the "Dropins" folder?
Comment 14 ekkehard gentz CLA 2008-07-03 10:39:53 EDT
Created attachment 106444 [details]
bundle.info

the "configuration" directory of e34pool is empty

but the "configuration" diretory of e34modeling has an
"org.eclipse.equinox.simpleconfigurator" directory containing a "bundles.info"
file.
see attached
and this file contain entries from the "Dropins" folder

for me this is OK, because this dropins folder is local to e34modeling Eclipse Application.

another Eclipse Application (e34osgi_rcp) has also an "own" dropins folder

both applications use their local dropins folder together with the bundle pool

why should the bundle pool have knowledge of the dropins folders located at applications which share the bundle pool, but not their dropins

its also possible to have an extra dropins folder (as I desribed in my blog http://ekkes-corner.blogspot.com/2008/06/eclipse-ganymede-p2-shared.html) using 
-Dorg.eclipse.equinox.p2.reconciler.dropins.directory
in the eclipse.ino of the Eclipse Application
Comment 15 Darin Wright CLA 2008-07-03 10:43:56 EDT
OK, so I think this is a dup of bug 235336 - PDE is not getting the correct configuration location in this case and we are scanning all bunldes in the location rather than using the correct bundles.info.

*** This bug has been marked as a duplicate of bug 235336 ***
Comment 16 ekkehard gentz CLA 2008-07-09 01:37:13 EDT
thanks, darin,
so I'll watch bug 235336 and test again after fixing it.
ekke
Comment 17 ekkehard gentz CLA 2008-08-12 03:32:44 EDT
just tested with 3.5M1 and can confirm:
Bugfix 235336 also fixed this bug
thanks
ekke