Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 238796 - [Net] JSch non-proxy list should be considered case insensitive
Summary: [Net] JSch non-proxy list should be considered case insensitive
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 221843 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-27 10:30 EDT by Christian Domsch CLA
Modified: 2010-09-22 09:46 EDT (History)
4 users (show)

See Also:


Attachments
Patch_v1 (791 bytes, patch)
2008-08-06 05:05 EDT, Pawel Pogorzelski CLA
no flags Details | Diff
Patch_v2 (2.00 KB, patch)
2008-08-19 09:06 EDT, Pawel Pogorzelski CLA
no flags Details | Diff
Patch_v3 (2.00 KB, patch)
2008-08-20 03:57 EDT, Pawel Pogorzelski CLA
pawel.pogorzelski1: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Domsch CLA 2008-06-27 10:30:19 EDT
Build ID: I20080617-2000

Steps To Reproduce:
1. Have Proxy Environment (corporate e.g.)
2. Enter a non-proxy entry for the server you want to connect to with ssh in all lower case (which is standard)
3. Create the remote system to this server
4. Try to connect: it fails with [...].ProxyHTTP: forbidden

More information:
The ProxyHTTP class from JSCH tries to connect to the server through the proxy, though in the general settings of eclipse this server is excluded (its in the non-proxy host list). This is due to the fact, because the remote system target defines the server name in all uppercase letters and the non-proxy list is in all lowercase letters.
It seems that the target management plugin looks into the list and makes a case sensitive equals operation which clearly fails.

The workaround is to define the non-proxy host entry also in all uppercase letters.
Comment 1 Martin Oberhuber CLA 2008-06-27 10:36:23 EDT
The Proxy handling is not done by Target Management, it's all in the org.eclipse.jsch.core plugin which is owned by Platform/CVS.
Comment 2 Martin Oberhuber CLA 2008-06-27 10:38:20 EDT
Changed summary, previous value was:
SSH Connections fails in proxy environment
Comment 3 Martin Oberhuber CLA 2008-07-01 11:01:30 EDT
Atsuhiko, can you investigate this?
Comment 4 Szymon Brandys CLA 2008-07-01 11:44:15 EDT
Another steps:
1) Add :pserver:anonymous@DEV.ECLIPSE.ORG:/cvsroot/eclipse repository
2) Use manual proxy conf and set incorrect HTTP and SOCKS proxy
3) Add dev.eclipse.org to the non-proxied hosts list
4) try to do any operation on the repo - doesn't work

5) Add DEV.ECLIPSE.ORG to the non-proxied hosts list
6) try to do any operation on the repo - works

This is a bug in the proxy manager. Not related to Atsuhiko's stuff.
I'll handle it.
Comment 5 Pawel Pogorzelski CLA 2008-08-06 05:05:45 EDT
Created attachment 109281 [details]
Patch_v1
Comment 6 Pawel Pogorzelski CLA 2008-08-19 09:06:20 EDT
Created attachment 110335 [details]
Patch_v2

After Szymon's recomendation I added a regression test. How does it look now?
Comment 7 Szymon Brandys CLA 2008-08-19 11:38:50 EDT
Looks good. I would rename the test method to testBug238796 to keep the convention.
Comment 8 Pawel Pogorzelski CLA 2008-08-20 03:57:15 EDT
Created attachment 110418 [details]
Patch_v3
Comment 9 Tomasz Zarna CLA 2008-08-21 04:00:01 EDT
Released to HEAD.
Comment 10 Martin Oberhuber CLA 2010-09-22 09:46:35 EDT
*** Bug 221843 has been marked as a duplicate of this bug. ***