Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 238452 - [Browser] External browser parameters are not passed to external browser
Summary: [Browser] External browser parameters are not passed to external browser
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 104701 (view as bug list)
Depends on:
Blocks: 464153
  Show dependency tree
 
Reported: 2008-06-25 14:14 EDT by John J. Barton CLA
Modified: 2016-02-08 08:34 EST (History)
3 users (show)

See Also:


Attachments
Patch (13.96 KB, patch)
2008-10-27 17:33 EDT, Chris Goldthorpe CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John J. Barton CLA 2008-06-25 14:14:35 EDT
Build ID: I20080609-1311

Steps To Reproduce:
1.When I set values in to the Edit External Web Browser dialog from
Window->Preferences->General->WebBrowser->Use external web browse->Edit
these parameters have no effect. 
2.
3.


More information:
The buggy code is in org.eclipse.ui.internal.browser.browsers.MozillaFactory.createBrowser(String, String, String)	

public IWebBrowser createBrowser(String id, String location, String parameters) {
		// Create single browser for all clients
		if (browserInstance == null) {
			browserInstance = new MozillaBrowser(id, location);
		}
		return browserInstance;
	}

Parameters are ignored
Comment 1 Chris Goldthorpe CLA 2008-07-03 14:08:33 EDT
Targeting Eclipse 3.5. 
Comment 2 Chris Goldthorpe CLA 2008-10-27 17:33:46 EDT
Created attachment 116228 [details]
Patch
Comment 3 Chris Goldthorpe CLA 2008-10-27 17:34:24 EDT
Fixed in HEAD
Comment 4 Chris Goldthorpe CLA 2009-04-08 22:58:11 EDT
*** Bug 104701 has been marked as a duplicate of this bug. ***