Community
Participate
Working Groups
For frequent Mylyn users task submission is a very common command, and as such we should provide a shortcut. I think that the Alt+S shortcut is the most common one in mail tools, so +1 for that.
Please be careful with "Alt" shortcuts. For instance, Alt-S is the "Source" menu shortcut
How about Ctrl+Shift+S?
Forget me for stating the obvious, but all present key bindings can be seen on Window / Preferences... / General / Keys. For instance Ctrl-Shift-S is bound to "Save All" action.
Alt+S still seems like a good candidate to me, even it is the Source menu in the Java editor, unless we think that people would get confused between these two shortcuts.
Personally I don't like when components hijaking global menu shortcuts, e.g. Alt-S is expected to open source menu and it is confusing then it does something else. Also, editors are supposed to put some of their actions into the source menu. For instance, "format" action may actually make sense even in the task editor, then wiki formatting could have other actions for working with the source code.
While I agree that we should avoid conflicts with existing key-bindings or system key-bindings users can change the binding in the configuration. Since Alt+Shift+S and Ctrl+Shift+S are already taken I'm +1 for Alt+S.
Steffen, if one follow your logic, why don't leave no shortcut there and let user to decide rather then encourage bad practices?
Since the task editor does not have a Source menu Alt+S is currently not used so I am not sure if it matters in this case. I agree that generally not assigning a key-binding instead of a potentially conflicting one / one that breaks convention is the better approach. Mik, would you be okay with just having a command?
Yes, a command is fine, but I want us to figure out a very easy and obvious default, because for a frequent Mylyn user the shortcut for Submitting in the task editor needs to be as accessible as the shortcut for Save in a text editor. I still don't see a better tradeoff than Alt+S given that "S" is the right mnemonic and that Ctrl+Shift+S is hard to press because "S" is so close to the left modifier keys.
What about Ctrl-Enter? It is common across several email and im clients.
On it's own I think that combination makes a lot of sense. But it also has a usability problem, because it is too easy to invoke accidentally due to the fact that when typing fast you might still have your finger on the Ctrl key when hitting Enter (e.g. right after having hit Ctrl+S or Ctr+V). The problem is bad enough that Outlook 2007 now brings up a PONT (point of needed training) dialog whenever you do this, even though afaik it was their default shortcut for sending in previous versions. I'll attach a screenshot of the dialog.
Created attachment 106183 [details] Ctrl+Enter dialog
(In reply to comment #11) > The problem is bad enough that Outlook 2007... Another solution would be to track keyboard events and only enable Ctrl-Enter action after Control been released, so it won't be accidental.
*** Bug 227012 has been marked as a duplicate of this bug. ***
The submit action is not bound to Shift+Alt+S in the task editor. This avoids conflict with menu accelarators and accidental submits when Alt+S is used to navigate to the menu. I have aded the keybindg to the UI_Nits wiki page.
Created attachment 109718 [details] mylyn/context/zip
Steffen: is the only known clash of Alt+S the Source menu in the Java perspective and related perspectives? I would like Mylyn to "claim" the Alt+S shortcut since it is so common and way easier to use than Alt+Shift+S, which is very hard to hit with the left hand alone (afaik modifier keys are more often use with the left hand). If it's just the Java perspective, I wonder if we could keep both Shift+Alt+S and selectively enable Alt+S.
We have to consider that the accelerator keys could be mapped differently in other languages. In that sense all Alt+x combinations are already claimed. Looking at the default Eclipse key-bindings all Alt combinations to a single letter include either Shift or Ctrl. Only special keys such as Enter or the arrow keys are bound without additional modifiers. Since the task editor does have a Source menu there is no conflict in the English version at the moment. I think it is sufficient that users can easily remap keys if needed but I have stated my case and leave it up to you to pick the default.
Is there a chance we get that keyboard shortcut activated in the task list. Especially when mass updating tickets it's very awkward to open up each and every ticket to do ALT+SHIFT+S on it. Simply selecting the relevant tasks or queries in the task list view and pressing that shortcut could submit all selected ones with outgoing changes.
Task submission is currently bound to the editor. We can't easily support that in the Task List at this point. We are tracking improving that workflow on bug 370414.
