This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 238288 - use ImageRegistry to store/retrieve images for RSE label providers
Summary: use ImageRegistry to store/retrieve images for RSE label providers
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 236505
Blocks:
  Show dependency tree
 
Reported: 2008-06-24 13:07 EDT by David McKnight CLA
Modified: 2009-05-06 12:34 EDT (History)
1 user (show)

See Also:

Attachments
experimental approach to using ImageRegistry (2.57 KB, patch)
2009-03-31 13:45 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2008-06-24 13:07:49 EDT 
Bug 236505 required a change to how images are stored and later disposed.  It turns out that we can reuse ImageRegistry for this purpose and since that seems to be a more standard approach, we should use that instead.
Comment 1 Martin Oberhuber CLA 2008-06-24 13:44:01 EDT 
Adding Uwe for any input that he might have.

I think that this "depends on" bug 236505 rather than blocking it, because the code that we essentially want to clean up here has been added with bug 236505.
Comment 2 Martin Oberhuber CLA 2008-09-23 11:08:34 EDT 
If it turns out that this can be done without adding API, I think this is a potential candidate for 3.0.2 since it can help saving resources. Therefore, when you address this, please add a patch here on bugzilla in order to simplify backporting, just in case.
Comment 3 Martin Oberhuber CLA 2008-09-30 09:17:56 EDT 
bulk update of target milestone
Comment 4 Martin Oberhuber CLA 2008-11-26 09:05:29 EST 
Dave, I think this is yours because you fixed bug 236505. Please set the target milestone as appropriate.
Comment 5 David McKnight CLA 2009-03-31 13:45:26 EDT 
Created attachment 130428 [details]
experimental approach to using ImageRegistry

Here's one way to use ImageRegistry.  In this case, I'm just using descriptor.toString() for the key.  I'm not sure whether this is the best way to deal with keys though.  Any thoughts?
Comment 6 David McKnight CLA 2009-04-21 15:55:17 EDT 
Martin, do you have any thoughts on whether descriptor.toString() is an appropriate key?
Comment 7 David McKnight CLA 2009-05-06 12:34:59 EDT 
I've committed the change to cvs.