Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 238235 - [Bundle-Localization] Default to /OSGI-INF/l10n/bundle.properties and not /plugin.properties
Summary: [Bundle-Localization] Default to /OSGI-INF/l10n/bundle.properties and not /pl...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-24 09:27 EDT by Philipp Kursawe CLA
Modified: 2008-12-01 16:28 EST (History)
3 users (show)

See Also:

Attachments
Patch changes default bundle localization to the default OSGi bundle localization (5.81 KB, patch)
2008-07-04 11:49 EDT, Philipp Kursawe CLA 		no flags Details | Diff
Additional patch for PDE core (20.77 KB, patch)
2008-07-04 11:52 EDT, Philipp Kursawe CLA 		caniszczyk: iplog+
Details | Diff
org.eclipse.pde.core.patch (19.33 KB, patch)
2008-11-30 17:39 EST, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (3.56 KB, application/octet-stream)
2008-11-30 17:39 EST, Chris Aniszczyk CLA 		no flags Details
org.eclipse.pde.patch (20.27 KB, patch)
2008-12-01 10:59 EST, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (1.87 KB, application/octet-stream)
2008-12-01 12:09 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Kursawe CLA 2008-06-24 09:27:21 EDT 
Due to legacy reasons I assume the default localization of bundles/plug-ins defaults to /plugin.properties. 

OSGi however specifies it to default to /OSGI-INF/l10n/bundle.properties. PDE ignores this fact. If the Bundle-Header does not contain a localization it will not correctly resolve the texts from the OSGi default localization. 
Furthermore when you want to externalize new strings it should localize them into the specified localization (which could be the default one if not specified) and not into /plugin.properties.

I think changing this behaviour would not break existing plugins and new OSGi bundle localization would be much easier to do.
Comment 1 Philipp Kursawe CLA 2008-07-03 10:01:05 EDT 
ok I have it almost finished. 
The only remaining problem are the non-refreshing tooltips that ManifestTextHover is producing. When I change the l10n file the model ManifestTextHover is not updated. The bundle editor seems to use 2 models. One I can update upon resource delta change, in WorkspacePluginModelManager.handleBundleManifestDelta() I call ((AbstractNLModel) model).resetNLResourceHelper(); But I need also to update the model that is used in ManifestTextHover. Anyone has a clue?
Comment 2 Philipp Kursawe CLA 2008-07-04 11:49:55 EDT 
Created attachment 106597 [details]
Patch changes default bundle localization to the default OSGi bundle localization
Comment 3 Philipp Kursawe CLA 2008-07-04 11:52:47 EDT 
Created attachment 106598 [details]
Additional patch for PDE core
Comment 4 Darin Wright CLA 2008-07-07 09:52:31 EDT 
Consider for 3.5
Comment 5 Chris Aniszczyk CLA 2008-11-30 17:39:08 EST 
Created attachment 119099 [details]
org.eclipse.pde.core.patch

Updated patch to not break old-style plug-ins.
Comment 6 Chris Aniszczyk CLA 2008-11-30 17:39:12 EST 
Created attachment 119100 [details]
mylyn/context/zip
Comment 7 Chris Aniszczyk CLA 2008-12-01 10:59:49 EST 
Created attachment 119156 [details]
org.eclipse.pde.patch

An updated patch to include a test case.
Comment 8 Chris Aniszczyk CLA 2008-12-01 12:09:48 EST 
done.

> 20091201

Thanks for your initial patch Philipp.
Comment 9 Chris Aniszczyk CLA 2008-12-01 12:09:52 EST 
Created attachment 119172 [details]
mylyn/context/zip
Comment 10 Philipp Kursawe CLA 2008-12-01 16:21:47 EST 
Chris, that test contains a typing error for the Bundle-SymbolicName :)
Comment 11 Chris Aniszczyk CLA 2008-12-01 16:28:49 EST 
Thanks.

Thankfully that's what wasn't being tested in this case, hah ;)