This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 237380 - Two menu items lead to the same dialog box
Summary: Two menu items lead to the same dialog box
Status: VERIFIED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Cosmos (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sheldon Lee-Loy CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-16 17:48 EDT by Hubert Leung CLA
Modified: 2012-01-03 13:48 EST (History)
1 user (show)

See Also:

Attachments
Patch (20.73 KB, patch)
2008-06-20 12:37 EDT, Sheldon Lee-Loy CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hubert Leung CLA 2008-06-16 17:48:35 EDT 
I see that the "Submit Query as Text..." option added in the popup menu in i11.

If an MDR does not have metadata defined (e.g. the SML MDR), both "Submit
Query..." and "Submit Query as Text..." will lead to the same dialog box.  

Is it possible to hide the "Submit Query..." option if metadata is not
available, so that we won't have two menu items to lead to the same dialog box?
Comment 1 John Todd CLA 2008-06-17 08:50:39 EDT 
Would it be sufficient to predetermine which MDRs have metadata and which don't?
by that I mean, for example we know the SML MDR does not, so we could just take out the 'Submit Query with Text' option for that specific MDR and so on.
Making it dynamic to say 'when you click on an MDR, you don't get 'Submit Query with Text' if there is no metadata associated with the MDR' is unknown and potentially impossible complexity.

- JT
Comment 2 Sheldon Lee-Loy CLA 2008-06-17 10:21:31 EDT 
I think we just need to change the logic for the Submit Query menu.  It shouldn't be shown if the mdr doesn't have meta data.  

This is simple to do.
Comment 3 John Todd CLA 2008-06-17 10:23:55 EDT 
I was going to say, well could you do it then, but then I see it is actually assigned to you and not me, so that's good.

- JT
Comment 4 Sheldon Lee-Loy CLA 2008-06-20 12:37:28 EDT 
Created attachment 105510 [details]
Patch
Comment 5 Sheldon Lee-Loy CLA 2008-06-27 11:43:14 EDT 
Applied patch to i12.
Comment 6 Sheldon Lee-Loy CLA 2008-08-28 12:26:29 EDT 
Verified bug with build COSMOS-1.0.0-200808271150